Merge ~thogarre/charm-hw-health:remove-sudo-ipmi-logging into charm-hw-health:master

Proposed by Garrett Neugent
Status: Merged
Approved by: James Troup
Approved revision: 4d051d5fd1382eac709ace0c884612211d6bd6e0
Merged at revision: 6ac3819b3e7f9522d75f790229cb61f38a95996e
Proposed branch: ~thogarre/charm-hw-health:remove-sudo-ipmi-logging
Merge into: charm-hw-health:master
Diff against target: 9 lines (+3/-1)
1 file modified
src/files/ipmi/99-check_ipmi_sensor (+3/-1)
Reviewer Review Type Date Requested Status
Zachary Zehring (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+408111@code.launchpad.net

Commit message

Prevent logging sudo ipmi commands during checks

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zachary Zehring (zzehring) wrote :

LGTM +1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 6ac3819b3e7f9522d75f790229cb61f38a95996e

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/files/ipmi/99-check_ipmi_sensor b/src/files/ipmi/99-check_ipmi_sensor
2index ead55da..85e3886 100644
3--- a/src/files/ipmi/99-check_ipmi_sensor
4+++ b/src/files/ipmi/99-check_ipmi_sensor
5@@ -1 +1,3 @@
6-nagios ALL=(root) NOPASSWD: /usr/sbin/ipmimonitoring, /usr/sbin/ipmi-dcmi, /usr/sbin/ipmi-fru, /usr/sbin/ipmi-sensors, /usr/sbin/ipmi-sel
7+Cmnd_Alias IPMI = /usr/sbin/ipmi-dcmi, /usr/sbin/ipmi-fru, /usr/sbin/ipmimonitoring, /usr/sbin/ipmi-sel, /usr/sbin/ipmi-sensors
8+nagios ALL = (root) NOPASSWD: IPMI
9+Defaults!IPMI !logfile, !syslog, !pam_session

Subscribers

People subscribed via source and target branches

to all changes: