Merge lp:~thisfred/u1db/u1todo-sync2 into lp:u1db
Proposed by
Eric Casteleijn
on 2012-05-08
| Status: | Merged |
|---|---|
| Approved by: | Eric Casteleijn on 2012-05-08 |
| Approved revision: | 273 |
| Merged at revision: | 269 |
| Proposed branch: | lp:~thisfred/u1db/u1todo-sync2 |
| Merge into: | lp:u1db |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~thisfred/u1db/u1todo-sync2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Diego Sarmentero (community) | 2012-05-08 | Approve on 2012-05-08 | |
| Roberto Alsina (community) | Approve on 2012-05-08 | ||
|
Review via email:
|
|||
Description of the Change
Added a sync tab to the ui, and a button to sync with Ubuntu One
Fixed some UI issues
known issues that will be fixed (not now because aq needs this for a workshop ASAP)
- u1todo is now linux specific and depends on dbus. yech
- nothing is persisted between sessions, so if you add your own server/db to sync with, it will be forgotten.
- no way to add credentials to non u1 servers.
- the sync code is in u1todo, but will move into u1db proper, and be refactored so that the command line client, and the library code all use the same bits.
To post a comment you must log in.
lp:~thisfred/u1db/u1todo-sync2
updated
on 2012-05-08
- 270. By Eric Casteleijn on 2012-05-08
-
deduplicate code
lp:~thisfred/u1db/u1todo-sync2
updated
on 2012-05-08
- 271. By Eric Casteleijn on 2012-05-08
-
handle no selected row
- 272. By Eric Casteleijn on 2012-05-08
-
handle no selected row
- 273. By Eric Casteleijn on 2012-05-08
-
better method name
+1
However!
Please refactor the strike font into a method of the item class, and make sure you are checking that items you get from the list are not None.