Merge lp:~thisfred/desktopcouch/eq_ne into lp:desktopcouch

[Eric Casteleijn]

Added __eq__ and __ne__ to MergeableList class so they can be compared to regular lists.

By popular demand: it's now possible to compare mergeable lists to regular list objects (or anything that's a MutableSequence)

[Chad Miller (cmiller)]

Nice! I'd like to see some deeper structure in the tests.

[Chad Miller (cmiller)]

review: Approve

[James Tait (jamestait)]

Like Chad, I'd like to see a bit more depth in the tests, but it looks reasonable.

review: Approve

=== modified file 'desktopcouch/records/__init__.py'
--- desktopcouch/records/__init__.py	2010-11-23 19:46:06 +0000
+++ desktopcouch/records/__init__.py	2011-01-04 19:37:17 +0000
@@ -276,6 +276,19 @@
             return len(self._data) - 1
         return len(self._data)
 
+    def __eq__(self, other):
+        if not isinstance(other, MutableSequence):
+            return False
+        if len(self) != len(other):
+            return False
+        for i in range(len(self)):
+            if self[i] != other[i]:
+                return False
+        return True
+
+    def __ne__(self, other):
+        return not self.__eq__(other)
+
     def insert(self, index, value):
         """Insert value at index."""
         new_uuid = str(uuid.uuid4())

=== modified file 'desktopcouch/records/tests/test_record.py'
--- desktopcouch/records/tests/test_record.py	2010-11-23 18:47:46 +0000
+++ desktopcouch/records/tests/test_record.py	2011-01-04 19:37:17 +0000
@@ -87,6 +87,28 @@
         self.assertEqual("bar", mergeable_list[1])
         self.assertEqual("bar", mergeable_list[-1])
 
+    def test_eq(self):
+        """Test comparison of regular lists to mergeable lists."""
+        the_list = ['foo', 'bar', 'baz']
+        mergeable_list = MergeableList(the_list)
+        self.assertEqual(mergeable_list, the_list)
+        self.assertEqual(mergeable_list, mergeable_list)
+
+    def test_eq2(self):
+        """Test comparison of regular lists to mergeable lists."""
+        the_list = [{'foo': 'bar'}, {'baz': 'qux'}, {'fnord': 'fierljeppen'}]
+        mergeable_list = MergeableList(the_list)
+        self.assertEqual(mergeable_list, the_list)
+        self.assertEqual(mergeable_list, mergeable_list)
+
+    def test_ne(self):
+        """Test comparison of regular lists to mergeable lists."""
+        the_list = ['foo', 'bar', 'baz']
+        mergeable_list = MergeableList(the_list)
+        self.assertNotEqual([], mergeable_list)
+        self.assertNotEqual([1, 2, 3], mergeable_list)
+        self.assertNotEqual('peanut butter & chocolate', mergeable_list)
+
     def test_del(self):
         """Test deletion of uuid keys."""
         mergeable_list = MergeableList(['foo', 'bar', 'baz'])