Merge lp:~thibaultfevry/cardapio/no_subprocess_for_platform into lp:cardapio

[Thibault Févry]

 Use Python Std Library to get distribution name.

 I looked at the code, and the fact that you used subprocess to get distribution name bogged me, so I made it use Python Std Library instead (Subproccess has more hidden bugs and many python programmers consider it "evil"). The function is documented here : http://docs.python.org/library/platform.html#unix-platforms . If you want backwards compatibility with Python version < 2.5 you may want to use platform.dist() instead of platform.linux_distribution(), but this only changes the function name.

[Thibault Févry (thibaultfevry)]

 I just want to add that I made an error with the indentation level (I use 4 spaces and not tabs), so you have to change this before it works. This is also untested in the programm itself but the results given by the 2 commands are the same.

[lp:~thibaultfevry/cardapio/no_subprocess_for_platform]

483. By Thibault Févry on 2010-11-08

Use project indentation : Tab instead of 4 spaces.

[Thiago Teixeira (tvst)]

Thanks for the code, and for letting me know about Subprocess. I will take a look at your branch tonight.

Cheers!

[Thiago Teixeira (tvst)]

Merged! Thanks for posting this.

Removing these "hacky" lines are always a good thing, so your bug report was right on point. So, in that same direction: Do you happen to know an alternative way to get the output of the "which" command in Python?

This would allow us to *completely* remove our reliance on the "commands"/"subprocess" modules in Cardapio :)

[Thibault Févry (thibaultfevry)]

 I think there's a which.py in python tools (Which comes with the windows version, and that you should be able to download in linux). There is also this thread : http://<email address hidden>/msg250218.html that gives some explanations and gives a link to this : http://code.google.com/p/which/

 So, there isn't really a similar function in python library, but I think it's better to include a light python function (The google project as many other things you don't need.) to get the output than use a subrprocess call. This would be faster, more pythonnic and less buggy. (Someone could have an alias for which in their system for example.)

[Thiago Teixeira (tvst)]

Ok, I just added the "which" code into Cardapio and now we don't depend on superfluous uses of either "command" or "subprocess". Thanks for the help!

=== modified file 'src/cardapio.py'
--- src/cardapio.py	2010-11-08 13:41:56 +0000
+++ src/cardapio.py	2010-11-08 21:24:51 +0000
@@ -56,6 +56,7 @@
 	import keybinder
 	import subprocess
 	import dbus, dbus.service
+    import platform
 
 	from time import time
 	from pango import ELLIPSIZE_END
@@ -149,7 +150,7 @@
 
 class Cardapio(dbus.service.Object):
 
-	distro_name = getoutput('lsb_release -is')
+    distro_name = platform.linux_distribution()[0]
 
 	MIN_VISIBILITY_TOGGLE_INTERVAL    = 0.200 # seconds (this is a bit of a hack to fix some focus problems)
 	PANEL_SIZE_CHANGE_IGNORE_INTERVAL = 200 # milliseconds
@@ -207,7 +208,7 @@
 
 		logging.info('----------------- Cardapio launched -----------------')
 		logging.info('Cardapio version: %s' % Cardapio.version)
-		logging.info('Distribution: %s' % getoutput('lsb_release -ds'))
+		logging.info('Distribution: %s' % " ".join(platform.linux_distribution()[:2]))
 
 		self.home_folder_path = os.path.abspath(os.path.expanduser('~'))