Merge lp:~therve/storm/276690-variable-hash into lp:storm

[Thomas Herve]

[James Henstridge (jamesh)]

Looks pretty good. Two small issues:

[1]
there are a few lines in storm/store.py that could do with wrapping or splitting into multiple statements using a temporary variable (primary_vars => primary_vals maybe?)

[2]
Could you use the assertVariablesEqual() helper for your changes in tests/properties.py?

review: Approve

[Thomas Herve (therve)]

Thanks, both points addressed!

[lp:~therve/storm/276690-variable-hash]

274. By Thomas Herve on 2008-10-06

 * Use temporary variables in store.py to lighten the code
 * Use assertVariablesEqual in tests/properties.py instead of manual checking

[Gustavo Niemeyer (niemeyer)]

<niemeyer> therve: Your branch 276690-variable-hash looks very good
<therve> niemeyer: cool!
<therve> I got some nice comments from James
<niemeyer> therve: I was wondering about putting that algorithm we do frequently in a single place
<niemeyer> therve: The building of the alive key
<niemeyer> therve: But that may be done in a second moment

review: Approve