Merge lp:~therve/landscape-client/network-activity-schema into lp:~landscape/landscape-client/trunk

[Thomas Herve]

[Free Ekanayaka (free.ekanayaka)]

Nice! +1

[1]

+ {"activities": Dict(String(), List(Tuple(Int(), Int(), Int())))})

Please add a comment describing what the format of this dict is, like

# Dict maps interfaces to their network activity. The network activity of an
# interface a is a list of 3-tuples (step, in, out), where 'step' is the time
# interval and 'in'/'out' are number of bytes received/sent over the interval.

[2]

+ {"activities": Dict(String(), List(Tuple(Int(), Int(), Int())))})

Just as a minor point "activities" plural doesn't sound quite right to me, grammatically.. can you have "network activities" plural? I think the term "network activity" is always use in singular form, but I might be wrong.

Some native speaker an perhaps comment on this?

review: Approve

[Jamu Kakar (jkakar)]

Looks good to me. As far as "activities" vs. "activity", I think
either are fine in this case. You could also use "bandwidth" or
"statistics".

+1!

review: Approve

[lp:~therve/landscape-client/network-activity-schema]

259. By Thomas Herve on 2010-06-11

Add comment