Merge lp:~therve/landscape-client/fake-package-installer into lp:~landscape/landscape-client/trunk

[Thomas Herve]

This is meant to be used on load-testing, so that we can create package activities against the clients which are running on the same machine. It's pretty basic right now, but we can enhance later if necessary (ie, require approvals, or fail sometimes).

[Free Ekanayaka (free.ekanayaka)]

Looks good, +1!

Out of curiosity do you plan to run a real "master" client on a machine alongside a bunch of fake ones? Otherwise I guess this fake will reply the right thing but won't actually modify the machine's state.

[Free Ekanayaka (free.ekanayaka)]

review: Approve

[Kevin McDermott (bigkevmcd)]

Looks fine to me, +1

review: Approve

=== added file 'landscape/manager/fakepackagemanager.py'
--- landscape/manager/fakepackagemanager.py	1970-01-01 00:00:00 +0000
+++ landscape/manager/fakepackagemanager.py	2011-08-12 08:22:23 +0000
@@ -0,0 +1,57 @@
+import logging
+import os
+import random
+
+from twisted.internet.utils import getProcessOutput
+from twisted.internet.defer import succeed
+
+from landscape.package.store import PackageStore
+from landscape.package.changer import PackageChanger
+from landscape.package.releaseupgrader import ReleaseUpgrader
+from landscape.manager.plugin import ManagerPlugin
+from landscape.manager.manager import SUCCEEDED
+
+
+class FakePackageManager(ManagerPlugin):
+
+    run_interval = 1800
+    randint = random.randint
+
+    def register(self, registry):
+        super(FakePackageManager, self).register(registry)
+        self.config = registry.config
+
+        registry.register_message("change-packages",
+                                  self.handle_change_packages)
+        registry.register_message("change-package-locks",
+                                  self.handle_change_package_locks)
+        registry.register_message("release-upgrade",
+                                  self.handle_release_upgrade)
+
+    def _handle(self, response):
+        delay = self.randint(30, 300)
+        self.registry.reactor.call_later(
+            delay, self.manager.broker.send_message, response, urgent=True)
+
+    def handle_change_packages(self, message):
+        response = {"type": "change-packages-result",
+                    "operation-id": message.get("operation-id"),
+                    "result-code": 1,
+                    "result-text": "OK done."}
+        return self._handle(response)
+
+    def handle_change_package_locks(self, message):
+        response = {"type": "operation-result",
+                    "operation-id": message.get("operation-id"),
+                    "status": SUCCEEDED,
+                    "result-text": "Package locks successfully changed.",
+                    "result-code": 0}
+        return self._handle(response)
+
+    def handle_release_upgrade(self, message):
+        response = {"type": "operation-result",
+                    "operation-id": message.get("operation-id"),
+                    "status": SUCCEEDED,
+                    "result-text": "Successful release upgrade.",
+                    "result-code": 0}
+        return self._handle(response)

=== added file 'landscape/manager/tests/test_fakepackagemanager.py'
--- landscape/manager/tests/test_fakepackagemanager.py	1970-01-01 00:00:00 +0000
+++ landscape/manager/tests/test_fakepackagemanager.py	2011-08-12 08:22:23 +0000
@@ -0,0 +1,70 @@
+from landscape.manager.plugin import SUCCEEDED
+
+from landscape.manager.fakepackagemanager import FakePackageManager
+from landscape.tests.helpers import LandscapeTest, ManagerHelper
+
+
+class FakePackageManagerTest(LandscapeTest):
+    """Tests for the fake package manager plugin."""
+
+    helpers = [ManagerHelper]
+
+    def setUp(self):
+        super(FakePackageManagerTest, self).setUp()
+        self.package_manager = FakePackageManager()
+        self.package_manager.randint = lambda x, y: 0
+
+    def test_handle_change_packages(self):
+        """
+        L{FakePackageManager} is able to handle a C{change-packages} message,
+        creating a C{change-packages-result} in response.
+        """
+        self.manager.add(self.package_manager)
+        service = self.broker_service
+        service.message_store.set_accepted_types(["change-packages-result"])
+        message = {"type": "change-packages", "operation-id": 1}
+        self.manager.dispatch_message(message)
+        self.manager.reactor.advance(1)
+
+        self.assertMessages(service.message_store.get_pending_messages(),
+                            [{"type": "change-packages-result",
+                              "result-text": "OK done.",
+                              "result-code": 1, "operation-id": 1}])
+
+    def test_handle_change_package_locks(self):
+        """
+        L{FakePackageManager} is able to handle a C{change-package-locks}
+        message, creating a C{operation-result} in response.
+        """
+        self.manager.add(self.package_manager)
+        service = self.broker_service
+        service.message_store.set_accepted_types(["operation-result"])
+        message = {"type": "change-package-locks", "operation-id": 1}
+        self.manager.dispatch_message(message)
+        self.manager.reactor.advance(1)
+
+        self.assertMessages(service.message_store.get_pending_messages(),
+                            [{"type": "operation-result",
+                              "result-text":
+                                  "Package locks successfully changed.",
+                              "result-code": 0, "status": SUCCEEDED,
+                              "operation-id": 1}])
+
+    def test_handle_release_upgrade(self):
+        """
+        L{FakePackageManager} is able to handle a C{release-upgrade} message,
+        creating a C{operation-result} in response.
+        """
+        self.manager.add(self.package_manager)
+        service = self.broker_service
+        service.message_store.set_accepted_types(["operation-result"])
+        message = {"type": "release-upgrade", "operation-id": 1}
+        self.manager.dispatch_message(message)
+        self.manager.reactor.advance(1)
+
+        self.assertMessages(service.message_store.get_pending_messages(),
+                            [{"type": "operation-result",
+                              "result-text":
+                                  "Successful release upgrade.",
+                              "result-code": 0, "status": SUCCEEDED,
+                              "operation-id": 1}])

=== modified file 'landscape/manager/tests/test_packagemanager.py'
--- landscape/manager/tests/test_packagemanager.py	2011-07-05 05:09:11 +0000
+++ landscape/manager/tests/test_packagemanager.py	2011-08-12 08:22:23 +0000
@@ -13,12 +13,12 @@
 
 
 class PackageManagerTest(LandscapeTest):
-    """Tests for the temperature plugin."""
+    """Tests for the package manager plugin."""
 
     helpers = [EnvironSaverHelper, ManagerHelper]
 
     def setUp(self):
-        """Initialize test helpers and create a sample thermal zone."""
+        """Initialize test helpers and create a sample package store."""
         super(PackageManagerTest, self).setUp()
         self.package_store = PackageStore(os.path.join(self.data_path,
                                                        "package/database"))