Merge lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:~webaddons-core-editors/web-addons/7.0

[Holger Brunn (Therp)]

This is weird: Launchpad says this was merged, but I can't see the code being added. Does anyone have an idea what went wrong here?

I simply resubmit this MP

----
A widget restoring the old behavior of many2one fields in tree views

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Very interesting! Seems fine
Thanks

review: Approve (code review)

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Nice !

it works perfectly.

review: Approve (functional test)

[Stefan Rijnhart (Opener) (stefan-opener)]

You reused the same branch for web_ckeditor4, removing web_tree_many2one_clickable in the same commit as adding that module. When web_ckeditor4 was merged, the revisions were adopted in lp:web-addons, while the changes were reverted at the same time.

You will need to reapply the changes in a new revision.

review: Needs Resubmitting

[Stefan Rijnhart (Opener) (stefan-opener)]

To see what I mean, branch lp:web-addons and inspect using

    bzr status -r 9.2.2..13.1.1

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi,

Yes this is weird because launchpad says "Diff against target: 0 lines". Are you sure that your new MP is valid ?

Regards.

review: Needs Information (no review)

[lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable]

12. By Holger Brunn (Therp) on 2014-04-30

[MRG] web-addons

13. By Holger Brunn (Therp) on 2014-04-30

[ADD] readd web_tree_many2one_clickable

[Holger Brunn (Therp) (hbrunn)]

Thanks for your input, now it should be okay

[Pedro Manuel Baeza (pedro.baeza)]

Please change description to fit in correct english to:

- This addon provides a widget to allow many2one fields in a tree view to open the linked resource:

but I have tried and it works correctly, so I'm not going to block MP.

Have you considered to have another module that completely replace default many2one widget with this functionality to avoid to reprogram all views?

Regards.

review: Approve (code review and test)

[lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable]

14. By Holger Brunn (Therp) on 2014-06-20

[IMP] attach one handler instead of inline javascript code. This way,
we don't lose the current breadcrumb

[Holger Brunn (Therp) (hbrunn)]

Thanks for your review Pedro! I basically rewrote the code, you might want to have another test.

The two colons are rst for preformatted text: http://docutils.sourceforge.net/docs/user/rst/quickref.html#literal-blocks

[Ronald Portier (Therp) (rportier1962)]

Tested it and it is working

review: Approve (test)

[Holger Brunn (Therp) (hbrunn)]

This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi Holger,

Maybe I'm fully lost, but I thought, for the OCA project, that we had to work on Launchpad for 7.0 (with sync on Github) and on Github for 8.0 serie.

Regards.

[Leonardo Pistone (lepistone)]

Hi Sylvain,

no, in the end we decided to move 7.0 to github as well.

Of course, in situations like that one where reviews were already done, we'll continue from where we are (no need to duplicate reviews).

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Thanks, I did'nt know that information.

Regards.

[Holger Brunn (Therp) (hbrunn)]

https://github.com/OCA/web/pull/10

Unmerged revisions

14. By Holger Brunn (Therp) on 2014-06-20

[IMP] attach one handler instead of inline javascript code. This way,
we don't lose the current breadcrumb

13. By Holger Brunn (Therp) on 2014-04-30

[ADD] readd web_tree_many2one_clickable

12. By Holger Brunn (Therp) on 2014-04-30

[MRG] web-addons

=== added directory 'web_tree_many2one_clickable'
=== added file 'web_tree_many2one_clickable/__init__.py'
--- web_tree_many2one_clickable/__init__.py	1970-01-01 00:00:00 +0000
+++ web_tree_many2one_clickable/__init__.py	2014-06-20 07:59:50 +0000
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################

=== added file 'web_tree_many2one_clickable/__openerp__.py'
--- web_tree_many2one_clickable/__openerp__.py	1970-01-01 00:00:00 +0000
+++ web_tree_many2one_clickable/__openerp__.py	2014-06-20 07:59:50 +0000
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name" : "Clickable many2one widget for tree views",
+    "version" : "1.0",
+    "author" : "Therp BV",
+    "complexity": "normal",
+    "description": """
+This addon provides a widget to have many2one fields in a tree view open the
+linked resource::
+
+<field name="partner_id" widget="many2one_clickable" />
+
+will open the linked partner in a form view.
+    """,
+    "category" : "Dependency",
+    "depends" : [
+        'web',
+    ],
+    "data" : [
+    ],
+    "js": [
+        'static/src/js/web_tree_many2one_clickable.js',
+    ],
+    "css": [
+    ],
+    "qweb": [
+    ],
+    "auto_install": False,
+    "installable": True,
+    "external_dependencies" : {
+        'python' : [],
+    },
+}

=== added directory 'web_tree_many2one_clickable/static'
=== added directory 'web_tree_many2one_clickable/static/src'
=== added directory 'web_tree_many2one_clickable/static/src/img'
=== added file 'web_tree_many2one_clickable/static/src/img/icon.png'
Binary files web_tree_many2one_clickable/static/src/img/icon.png	1970-01-01 00:00:00 +0000 and web_tree_many2one_clickable/static/src/img/icon.png	2014-06-20 07:59:50 +0000 differ
=== added directory 'web_tree_many2one_clickable/static/src/js'
=== added file 'web_tree_many2one_clickable/static/src/js/web_tree_many2one_clickable.js'
--- web_tree_many2one_clickable/static/src/js/web_tree_many2one_clickable.js	1970-01-01 00:00:00 +0000
+++ web_tree_many2one_clickable/static/src/js/web_tree_many2one_clickable.js	2014-06-20 07:59:50 +0000
@@ -0,0 +1,55 @@
+//-*- coding: utf-8 -*-
+//############################################################################
+//
+//   OpenERP, Open Source Management Solution
+//   This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+//
+//   This program is free software: you can redistribute it and/or modify
+//   it under the terms of the GNU Affero General Public License as
+//   published by the Free Software Foundation, either version 3 of the
+//   License, or (at your option) any later version.
+//
+//   This program is distributed in the hope that it will be useful,
+//   but WITHOUT ANY WARRANTY; without even the implied warranty of
+//   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+//   GNU Affero General Public License for more details.
+//
+//   You should have received a copy of the GNU Affero General Public License
+//   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+//
+//############################################################################
+
+openerp.web_tree_many2one_clickable = function(openerp)
+{
+    openerp.web.list.columns.add(
+            'field.many2one_clickable',
+            'instance.web_tree_many2one_clickable.Many2OneClickable');
+    openerp.web_tree_many2one_clickable.Many2OneClickable = openerp.web.list.Column.extend({
+        _format: function (row_data, options)
+        {
+            return _.str.sprintf('<a class="oe_form_uri" data-many2one-clickable-model="%s" data-many2one-clickable-id="%s">%s</a>',
+                this.relation,
+                row_data[this.id].value[0],
+                _.escape(row_data[this.id].value[1] || options.value_if_empty));
+        },
+    });
+
+    openerp.web.ListView.List.include({
+        render: function()
+        {
+            var result = this._super(this, arguments),
+                self = this;
+            this.$current.delegate('a[data-many2one-clickable-model]',
+                'click', function()
+                {
+                    self.view.do_action({
+                        type: 'ir.actions.act_window',
+                        res_model: jQuery(this).data('many2one-clickable-model'),
+                        res_id: jQuery(this).data('many2one-clickable-id'),
+                        views: [[false, 'form']],
+                    });
+                });
+            return result;
+        },
+    });
+}