Merge lp:~therp-nl/web-addons/7.0-web_popup_large into lp:~webaddons-core-editors/web-addons/7.0

[Stefan Rijnhart (Opener)]

This is a very small module to set default pop-up width in the web client to 95%, instead of the hardcoded 900 pixels.

If you think this module does not qualify for a community project because it is too trivial or the cosmetic change that it imposes is just arbitrary, let me know and I'll simply retract this proposal.

[lp:~therp-nl/web-addons/7.0-web_popup_large]

8. By Stefan Rijnhart (Opener) on 2013-09-19

[FIX] Fix the wording of the description in the module description

[Holger Brunn (Therp) (hbrunn)]

To make a point against this MP's arbitrarity: It actually helps usability if we use the screen efficiently. Further, 900px hurt on a small screen, then we also have to scroll horizontally sometimes.

review: Approve (code review)

[Pedro Manuel Baeza (pedro.baeza)]

I also see this as an usability improvement. Only one question: why the "if (!options.width)" check and not putting always options.width ='95%'?

Regards.

review: Needs Information (code review, no test)

[Stefan Rijnhart (Opener) (stefan-opener)]

@Pedro: because the options dictionary can be filled with a distinct values for the various parameters. We only want to set a default.

[Nhomar - Vauxoo (nhomar)]

For me is good.

I tested and i think it is so trivial but useful....

Regards.

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

@Stefan, OK, I get it. Thanks for the explanation.

I proceed with the merge.

Regards.

review: Approve

=== added directory 'web_popup_large'
=== added file 'web_popup_large/__init__.py'
=== added file 'web_popup_large/__openerp__.py'
--- web_popup_large/__openerp__.py	1970-01-01 00:00:00 +0000
+++ web_popup_large/__openerp__.py	2013-09-19 10:29:04 +0000
@@ -0,0 +1,34 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name": "Large pop-ups in web client",
+    "version": "7.0.1.0",
+    "author": "Therp BV",
+    "category": 'Usability',
+    "description": """
+Pop-ups in the web client have a width of 900 pixels by default.
+This module changes this default width to 95% of the parent window.
+    """,
+    'website': 'https://launchpad.net/web-addons',
+    'depends': ['web'],
+    "license": 'AGPL-3',
+    "js": ['static/src/js/web_popup_large.js'],
+}

=== added directory 'web_popup_large/static'
=== added directory 'web_popup_large/static/src'
=== added directory 'web_popup_large/static/src/js'
=== added file 'web_popup_large/static/src/js/web_popup_large.js'
--- web_popup_large/static/src/js/web_popup_large.js	1970-01-01 00:00:00 +0000
+++ web_popup_large/static/src/js/web_popup_large.js	2013-09-19 10:29:04 +0000
@@ -0,0 +1,25 @@
+/* 
+
+   Copyright (C) 2013 Therp BV
+   License: GNU AFFERO GENERAL PUBLIC LICENSE
+            Version 3 or any later version
+
+   @authors: Holger Brunn ([e-mail])
+             Stefan Rijnhart ([e-mail])
+
+*/
+
+openerp.web_popup_large = function(instance) {
+    instance.web.Dialog.include({
+        init: function(parent, options, content)
+        {
+            if(!options) {
+                options = {}
+            }
+            if (!options.width) {
+                options.width = '95%';
+            }
+            return this._super(parent, options, content);
+        },
+    });
+}