Merge lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager into lp:~webaddons-core-editors/web-addons/6.1

Proposed by Holger Brunn (Therp)
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager
Merge into: lp:~webaddons-core-editors/web-addons/6.1
Diff against target: 14 lines (+6/-0)
1 file modified
web_widget_classes/static/src/xml/web_widget_classes.xml (+6/-0)
To merge this branch: bzr merge lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Needs Resubmitting
Review via email:

Description of the change

This makes the model classes usable for all view types. The definition in WidgetFrame is not strictly necessary any more, but it doesn't hurt, so I keep it for compatibility.

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

This project is now hosted on Please move your proposal there. This guide may help you

review: Needs Resubmitting
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Unmerged revisions

28. By Holger Brunn (Therp)

[IMP] attach model class to ViewManagerAction template, this way it can
be used for all view types

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'web_widget_classes/static/src/xml/web_widget_classes.xml'
2--- web_widget_classes/static/src/xml/web_widget_classes.xml 2013-12-12 10:57:43 +0000
3+++ web_widget_classes/static/src/xml/web_widget_classes.xml 2014-04-30 08:11:34 +0000
4@@ -6,4 +6,10 @@
5 this.attr('class', null);
6 </t>
7 </t>
8+ <t t-extend="ViewManagerAction">
9+ <t t-jquery="table:first">
10+ this.attr('t-att-class', '"' + this.attr('class') + ' oe_model_" + (self.dataset.model.replace(new RegExp("\\\\.","g"), "_"))');
11+ this.attr('class', null);
12+ </t>
13+ </t>
14 </templates>


People subscribed via source and target branches