Merge lp:~therp-nl/therp-addons/7.0-fetchmail_invoice_fix_context_lang into lp:~therp-nl/therp-addons/7.0

[Stefan Rijnhart (Opener)]

[Ronald Portier (Therp) (rportier1962)]

Stefan,

The code looks good to me. I just wonder: why bother about setting the language at all?

As far as I can see, it does not effect the creation of the invoice. And when printing, the language of the partner is (or should be) used.

Or am I missing something?

[Stefan Rijnhart (Opener) (stefan-opener)]

The reason is a couple of lines below, where I craft an easily recognizable name for each invoice:

_("Received by email from %s") % email_from

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

[Ronald Portier (Therp) (rportier1962)]

Tested and it works.

review: Approve

=== modified file 'fetchmail_invoice/model/fetchmail_invoice.py'
--- fetchmail_invoice/model/fetchmail_invoice.py	2013-08-23 06:53:00 +0000
+++ fetchmail_invoice/model/fetchmail_invoice.py	2013-09-06 14:57:34 +0000
@@ -42,8 +42,8 @@
         # As the scheduler is run without language,
         # set the administrator's language
         if not context.get('lang'):
-            context['lang'] = users_pool.read(
-                cr, uid, uid, ['context_lang'])['context_lang']
+            user = users_pool.browse(cr, uid, uid, context=context)
+            context['lang'] = user.partner_id.lang
 
         if custom_values is None:
             custom_values = {}