Merge lp:~therp-nl/server-env-tools/decouple_oe_sa into lp:~server-env-tools-core-editors/server-env-tools/7.0

[Holger Brunn (Therp)]

This module deactivates all bindings to openerp.com that come with the standard code:
    - update notifier code is deactivated and the function is overwritten
    - apps and updates menu items in settings are removed
    - help and account menu items in user menu are removed

[lp:~therp-nl/server-env-tools/decouple_oe_sa]

45. By Holger Brunn (Therp) on 2013-08-13

[FIX] actually override update_notification

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks! Works like a charm. The module name sounds a little unclear to me. How about 'disable_openerp_online'?

Also, there is still a suspicious class "upload_data_thread" in openerp/tools/misc.py that refers to an OpenERP submission page in its 'run' method. I can't find any place where it is called, but maybe you could disarm this method by way of monkeypatching, just for the sake of completeness (if not paranoia)?

review: Needs Information

[lp:~therp-nl/server-env-tools/decouple_oe_sa]

46. By Holger Brunn (Therp) on 2013-08-14

[IMP] renamed to disable_openerp_online
[ADD] icon curtesy to
http://commons.wikimedia.org/wiki/File:Oxygen480-actions-network-disconnect.svg
[IMP] disarmed openerp.tools.misc.upload_data_thread

[Holger Brunn (Therp) (hbrunn)]

Thanks for your suggestions! I also rst-fied the description and added an icon

[Ronald Portier (Therp) (rportier1962)]

Tested and worked without flaw.

Code review: looks good to me.

review: Approve

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve (lgtm, no test)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Sounds good to me. Thanks

review: Approve (code review, no test)

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks for the changes!

review: Approve (test, code review)

=== added directory 'disable_openerp_online'
=== added file 'disable_openerp_online/__init__.py'
--- disable_openerp_online/__init__.py	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/__init__.py	2013-08-14 07:49:49 +0000
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import model
+
+from openerp.tools.misc import upload_data_thread
+upload_data_thread.run = lambda x: None

=== added file 'disable_openerp_online/__openerp__.py'
--- disable_openerp_online/__openerp__.py	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/__openerp__.py	2013-08-14 07:49:49 +0000
@@ -0,0 +1,55 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name" : "Remove openerp.com bindings",
+    "version" : "1.0",
+    "author" : "Therp BV",
+    "complexity": "normal",
+    "description": """
+This module deactivates all bindings to openerp.com that
+come with the standard code:
+
+* update notifier code is deactivated and the function is overwritten
+* apps and updates menu items in settings are removed
+* help and account menu items in user menu are removed
+    """,
+    "category" : "",
+    "depends" : [
+        'base',
+        'mail',
+    ],
+    "data" : [
+        'data/ir_ui_menu.xml',
+        'data/ir_cron.xml',
+    ],
+    "js": [
+    ],
+    "css": [
+    ],
+    "qweb": [
+        'static/src/xml/base.xml',
+    ],
+    "auto_install": False,
+    "installable": True,
+    "external_dependencies" : {
+        'python' : [],
+    },
+}

=== added directory 'disable_openerp_online/data'
=== added file 'disable_openerp_online/data/ir_cron.xml'
--- disable_openerp_online/data/ir_cron.xml	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/data/ir_cron.xml	2013-08-14 07:49:49 +0000
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+        <record id="mail.ir_cron_module_update_notification" model="ir.cron">
+            <field name="active" eval="False" />
+        </record>
+    </data>
+</openerp>

=== added file 'disable_openerp_online/data/ir_ui_menu.xml'
--- disable_openerp_online/data/ir_ui_menu.xml	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/data/ir_ui_menu.xml	2013-08-14 07:49:49 +0000
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+        <delete model="ir.ui.menu" id="base.module_mi" />
+        <delete model="ir.ui.menu" id="base.menu_module_updates" />
+    </data>
+</openerp>

=== added directory 'disable_openerp_online/model'
=== added file 'disable_openerp_online/model/__init__.py'
--- disable_openerp_online/model/__init__.py	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/model/__init__.py	2013-08-14 07:49:49 +0000
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import publisher_warranty_contract

=== added file 'disable_openerp_online/model/publisher_warranty_contract.py'
--- disable_openerp_online/model/publisher_warranty_contract.py	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/model/publisher_warranty_contract.py	2013-08-14 07:49:49 +0000
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openerp.osv.orm import Model
+
+
+class publisher_warranty_contract(Model):
+    _inherit = 'publisher_warranty.contract'
+
+    def update_notification(self, cr, uid, ids, cron_mode=True, context=None):
+        pass

=== added directory 'disable_openerp_online/static'
=== added directory 'disable_openerp_online/static/src'
=== added directory 'disable_openerp_online/static/src/img'
=== added file 'disable_openerp_online/static/src/img/icon.png'
Binary files disable_openerp_online/static/src/img/icon.png	1970-01-01 00:00:00 +0000 and disable_openerp_online/static/src/img/icon.png	2013-08-14 07:49:49 +0000 differ
=== added directory 'disable_openerp_online/static/src/xml'
=== added file 'disable_openerp_online/static/src/xml/base.xml'
--- disable_openerp_online/static/src/xml/base.xml	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/static/src/xml/base.xml	2013-08-14 07:49:49 +0000
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<templates>
+    <t t-extend="UserMenu">
+        <t t-jquery="a[data-menu='account'], a[data-menu='help']">
+            this.parent().remove();
+        </t>
+    </t>
+</templates>