Code review comment for lp:~therp-nl/openupgrade-tools/7.0-add-database_cleanup
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Needs Fixing
(code review and test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi, Stefan, finally I have tried your module and it's fantastic. For the most of the sections, it works like intended, but in "Purge obsolete tables", I find some tables that cannot be removed due to foreign keys in other tables. Use DROP CASCADE is too risky to be implemented, but you can enclose removal in a try and warns user afterwards, but continuing with tables that possibly contain the foreign key it complains about.
Also a warn that it's convenient to remove obsolete fields before purging obsolete tables is a good improvements.
One more thing: if I try to click on line button to remove tables one by one, I get line form view, but button cannot be clicked. Maybe readonly attribute?
Thanks for this excellent module.
Regards.
P.S.: Don't you think this module better fits on server-env-tools?