Merge lp:~therp-nl/openupgrade-server/7.0-lp1226086-menu_parent_store into lp:openupgrade-server

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 4632
Proposed branch: lp:~therp-nl/openupgrade-server/7.0-lp1226086-menu_parent_store
Merge into: lp:openupgrade-server
Prerequisite: lp:~therp-nl/openupgrade-server/7.0-deferred_steps
Diff against target: 10 lines (+3/-0)
1 file modified
openerp/openupgrade/deferred_70.py (+3/-0)
To merge this branch: bzr merge lp:~therp-nl/openupgrade-server/7.0-lp1226086-menu_parent_store
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Approve
Review via email: mp+186944@code.launchpad.net

Commit message

[FIX] lp:1226086, compute menu parent store. Courtesy of Sylvain LE GAL.

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

doesn't it make sense to do that for all models with parent left/right fields?

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

I'll merge this now and delay a general treatment (if necessary) to later

review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Sorry for not responding. Need to find out whether ir_ui_menu is for some reason a special case, but we can do that with the next field at hand that introduces parent store. Thanks for merging!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/openupgrade/deferred_70.py'
2--- openerp/openupgrade/deferred_70.py 2013-09-22 18:52:32 +0000
3+++ openerp/openupgrade/deferred_70.py 2013-09-22 18:52:32 +0000
4@@ -53,3 +53,6 @@
5
6 def migrate_deferred(cr, pool):
7 sync_commercial_fields(cr, pool)
8+ # Newly introduced _parent_store on menu items leaves gaps
9+ # after upgrade of other modules for *some* reason. See lp:1226086
10+ pool.get('ir.ui.menu')._parent_store_compute(cr)

Subscribers

People subscribed via source and target branches