Merge lp:~therp-nl/openupgrade-server/7.0-improve_model_renames into lp:openupgrade-server

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 4615
Proposed branch: lp:~therp-nl/openupgrade-server/7.0-improve_model_renames
Merge into: lp:openupgrade-server
Diff against target: 33 lines (+6/-0)
2 files modified
openerp/addons/base/migrations/7.0.1.3/pre-migration.py (+4/-0)
openerp/openupgrade/openupgrade.py (+2/-0)
To merge this branch: bzr merge lp:~therp-nl/openupgrade-server/7.0-improve_model_renames
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Review via email: mp+168614@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

just verified that 'relation' in ir_model_fields operates on model names, which surprised me.

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/migrations/7.0.1.3/pre-migration.py'
2--- openerp/addons/base/migrations/7.0.1.3/pre-migration.py 2013-02-23 09:21:24 +0000
3+++ openerp/addons/base/migrations/7.0.1.3/pre-migration.py 2013-06-11 08:16:30 +0000
4@@ -43,6 +43,9 @@
5 }
6
7 xmlid_renames = []
8+model_renames = [
9+ ('ir.actions.url', 'ir.actions.act_url'),
10+ ]
11
12 def migrate_ir_attachment(cr):
13 # Data is now stored in db_datas column and datas is a function field
14@@ -162,5 +165,6 @@
15 openupgrade.drop_columns(cr, [('ir_actions_todo', 'action_id')])
16 openupgrade.rename_columns(cr, column_renames)
17 openupgrade.rename_xmlids(cr, xmlid_renames)
18+ openupgrade.rename_models(cr, model_renames)
19 migrate_ir_attachment(cr)
20 create_users_partner(cr)
21
22=== modified file 'openerp/openupgrade/openupgrade.py'
23--- openerp/openupgrade/openupgrade.py 2013-05-03 12:20:05 +0000
24+++ openerp/openupgrade/openupgrade.py 2013-06-11 08:16:30 +0000
25@@ -143,6 +143,8 @@
26 for (old, new) in model_spec:
27 logger.info("model %s: renaming to %s",
28 old, new)
29+ cr.execute('UPDATE ir_model SET model = %s '
30+ 'WHERE model = %s', (new, old,))
31 cr.execute('UPDATE ir_model_fields SET relation = %s '
32 'WHERE relation = %s', (new, old,))
33 # TODO: signal where the model occurs in references to ir_model

Subscribers

People subscribed via source and target branches