Code review comment for lp:~therp-nl/openupgrade-server/6.0-lp1025797-dangling_references

This proposal would solve the error, as well as bug 1025819, along with any other modules where deleted records cause problems.

However, I don't like the fact that records magically reappear during the migration, perhaps months after some administrator deleted them. That's why I recreated them as inactive records in my merge proposal.

How about a third option? Create a working table and copy all the dangling ir_model_data records there, then delete them. At the end of the migration, go through the working table and deactivate all the records that got recreated. That way, it's a general solution that doesn't require custom scripting for each module, you don't have to make up bogus values for the recreated records, but the deleted records still aren't visible.

If you agree in principle, I'll make a merge proposal for you to review. If you still prefer the current proposal, I can work around it by recreating the records before I start the migration.