Merge lp:~therp-nl/openupgrade-addons/7.0-fix_move_line_currency into lp:openupgrade-addons

[Stefan Rijnhart (Opener)]

[Sylvain LE GAL (GRAP) (sylvain-legal)]

It's OK for me.

However, when testing (rapid test), I didn't have the case with account_move_line with currency defined in 6.1. (The old values was Null).
What is the user case to have account_move_line with currency_id set ?

@Reviewers : the new constraints is _check_currency_company in account/account_move_line.py

review: Needs Information (code review & test)

[Stefan Rijnhart (Opener) (stefan-opener)]

> What is the user case to have account_move_line with currency_id set ?

Confirming a bank statement with currency set to the company currency
(using banking addons, but the code that set the move line currency was
native)

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

=== modified file 'account/migrations/7.0.1.1/pre-migration.py'
--- account/migrations/7.0.1.1/pre-migration.py	2013-09-09 20:56:30 +0000
+++ account/migrations/7.0.1.1/pre-migration.py	2013-09-20 10:30:53 +0000
@@ -45,7 +45,25 @@
     ('account.account_payment_term_15days', 'account.account_payment_term'),
     ]
 
+def fix_move_line_currency(cr):
+    """
+    In OpenERP 7.0, there is a new constraint on move lines
+    having their currency set to the company currency.
+    These would be happily created in OpenERP 6.1, specifically
+    from bank statements.
+    """
+    openupgrade.logged_query(
+        cr,
+        """
+        UPDATE account_move_line l
+        SET currency_id = NULL
+        FROM res_company c
+        WHERE l.company_id = c.id
+              AND l.currency_id = c.currency_id;
+        """)
+
 @openupgrade.migrate()
 def migrate(cr, version):
     openupgrade.rename_columns(cr, column_renames)
     openupgrade.rename_xmlids(cr, xmlid_renames)
+    fix_move_line_currency(cr)