Merge lp:~therp-nl/openupgrade-addons/6.1_membership into lp:openupgrade-addons/6.1

[Holger Brunn (Therp)]

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks! I see this column type change is a generic change in function fields of type 'selection'. Can't we conjure up a generic solution to always cast from type text to type varchar(0) in BaseModel.__auto_init()?

review: Needs Information

[Holger Brunn (Therp) (hbrunn)]

I had the same idea in the beginning, but you can't change the type of a column on which other objects (views in openerp's case mostly) depend. And I couldn't find a reliable way to first determine which views depend on a column and second if it's save to just drop them.

So I think it's safer to deal with that on a by-column base.

[Stefan Rijnhart (Opener) (stefan-opener)]

I thought you would have given it some thought already ;-)

In that case, a remark about this in the documentation of OpenUpgrade 6.1 would be much appreciated.

review: Approve

=== added file 'membership/migrations/6.1.0.1/pre-migration.py'
--- membership/migrations/6.1.0.1/pre-migration.py	1970-01-01 00:00:00 +0000
+++ membership/migrations/6.1.0.1/pre-migration.py	2012-12-09 16:47:26 +0000
@@ -0,0 +1,33 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This migration script copyright (C) 2012 Therp BV (<http://therp.nl>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openupgrade import openupgrade
+
[e-mail]()
+def migrate(cr, version):
+    #we need to drop this view because it depends on state
+    #it will be recreated anyway
+    cr.execute('''drop view report_membership''')
+    #type of functional selection fields changed from text to varchar
+    cr.execute('''
+      alter table membership_membership_line alter state type varchar''')
+    cr.execute('''
+      alter table res_partner alter membership_state type varchar''')