Merge lp:~therp-nl/openobject-addons/7.0-lp1213852-select_invoicing_contact_on_invoice_form into lp:openobject-addons/7.0

[Stefan Rijnhart (Opener)]

[Stéphane Bidoul (Acsone) (sbi)]

It seems to me the proposed patch may create difficulties when there is more than one invoice address defined, by resetting the user choice to the first invoice address found.

review: Needs Information (code review)

[Stefan Rijnhart (Opener) (stefan-opener)]

It seems to me that when you manually select an invoice contact, then the result of address_get() would be that same contact. However, you would need to make such a contact a customer/supplier to select it in the first place. Does that answer your question?

[Stéphane Bidoul (Acsone) (sbi)]

Yes, absolutely!

review: Approve (code review)

Unmerged revisions

9368. By Stefan Rijnhart (Opener) on 2013-08-19

[FIX] Select invoicing contact on invoice form

=== modified file 'account/account_invoice.py'
--- account/account_invoice.py	2013-07-12 06:58:43 +0000
+++ account/account_invoice.py	2013-08-19 09:55:40 +0000
@@ -480,6 +480,18 @@
 
     def onchange_partner_id(self, cr, uid, ids, type, partner_id,\
             date_invoice=False, payment_term=False, partner_bank_id=False, company_id=False):
+        # Select the preferred invoice contact, if any
+        if partner_id:
+            partner_invoice_id = self.pool.get('res.partner').address_get(
+                cr, uid, [partner_id], adr_pref=['invoice'])['invoice']
+            if partner_invoice_id != partner_id:
+                result = self.onchange_partner_id(
+                    cr, uid, ids, type, partner_invoice_id,
+                    date_invoice=date_invoice, payment_term=payment_term,
+                    partner_bank_id=partner_bank_id, company_id=company_id)
+                result['value']['partner_id'] = partner_invoice_id
+                return result
+
         partner_payment_term = False
         acc_id = False
         bank_id = False