Merge lp:~therp-nl/openobject-addons/6.1-lp1049199-delete_employees_before_resources into lp:openobject-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 7043
Proposed branch: lp:~therp-nl/openobject-addons/6.1-lp1049199-delete_employees_before_resources
Merge into: lp:openobject-addons/6.1
Diff against target: 15 lines (+2/-1)
1 file modified
hr/hr.py (+2/-1)
To merge this branch: bzr merge lp:~therp-nl/openobject-addons/6.1-lp1049199-delete_employees_before_resources
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+131323@code.launchpad.net

Description of the change

This is a modified version of revision 6990 of
lp:~openerp-dev/openobject-addons/6.1-opw-578933-nep with comments by Olivier Dony taken into account.

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Not Reproducible on Trunk. If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :
Revision history for this message
Cristian Salamea (ovnicraft) wrote :

Hello, this will merged ?
Its a locking bug.

Unmerged revisions

7043. By Stefan Rijnhart (Opener)

[FIX] Unlink employees before unlinking the associated resources

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr/hr.py'
2--- hr/hr.py 2012-01-31 13:36:57 +0000
3+++ hr/hr.py 2012-10-25 07:19:48 +0000
4@@ -184,9 +184,10 @@
5 resource = employee.resource_id
6 if resource:
7 resource_ids.append(resource.id)
8+ res = super(hr_employee, self).unlink(cr, uid, ids, context=context)
9 if resource_ids:
10 resource_obj.unlink(cr, uid, resource_ids, context=context)
11- return super(hr_employee, self).unlink(cr, uid, ids, context=context)
12+ return res
13
14 def onchange_address_id(self, cr, uid, ids, address, context=None):
15 if address: