Merge lp:~therp-nl/openerp-web/7.0-lp1175163-TypeError_in_subview_button into lp:openerp-web/7.0

Proposed by Stefan Rijnhart (Opener)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~therp-nl/openerp-web/7.0-lp1175163-TypeError_in_subview_button
Merge into: lp:openerp-web/7.0
Diff against target: 18 lines (+7/-1)
1 file modified
addons/web/static/src/js/views.js (+7/-1)
To merge this branch: bzr merge lp:~therp-nl/openerp-web/7.0-lp1175163-TypeError_in_subview_button
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+161825@code.launchpad.net
To post a comment you must log in.
3915. By Stefan Rijnhart (Opener)

[FIX] Indentation

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Fixed independently in revision <email address hidden> so closing this proposal.

Unmerged revisions

3915. By Stefan Rijnhart (Opener)

[FIX] Indentation

3914. By Isaac Richter

[FIX] TypeError in client JS when pressing subview button

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/views.js'
2--- addons/web/static/src/js/views.js 2013-04-17 13:34:38 +0000
3+++ addons/web/static/src/js/views.js 2013-05-08 18:32:24 +0000
4@@ -1370,7 +1370,13 @@
5 args.push(context);
6 return dataset.call_button(action_data.name, args).then(handler).then(function () {
7 if (self.ViewManager.ActionManager) {
8- self.ViewManager.ActionManager.__parentedParent.menu.do_reload_needaction();
9+ pm = self.ViewManager.ActionManager.__parentedParent;
10+ while((typeof pm.menu === 'undefined') && (typeof pm.__parentedParent !== 'undefined')) {
11+ pm = pm.__parentedParent;
12+ }
13+ if(typeof pm.menu !== 'undefined') {
14+ pm.menu.do_reload_needaction();
15+ }
16 }
17 });
18 } else if (action_data.type=="action") {