Merge lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web

Proposed by Holger Brunn (Therp) on 2014-04-07
Status: Rejected
Rejected by: Holger Brunn (Therp) on 2014-07-21
Proposed branch: lp:~therp-nl/ocb-web/lp1303829
Merge into: lp:ocb-web
Diff against target: 16 lines (+0/-2)
1 file modified
addons/web_kanban/static/src/js/kanban.js (+0/-2)
To merge this branch: bzr merge lp:~therp-nl/ocb-web/lp1303829
Reviewer Review Type Date Requested Status
OpenERP Community Backports 2014-04-07 Pending
Review via email: mp+214542@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

4177. By Holger Brunn (Therp) on 2014-04-07

[FIX] don't mess with the dataset's ids

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_kanban/static/src/js/kanban.js'
2--- addons/web_kanban/static/src/js/kanban.js 2014-01-17 10:19:43 +0000
3+++ addons/web_kanban/static/src/js/kanban.js 2014-04-07 14:09:23 +0000
4@@ -637,12 +637,10 @@
5 },
6 do_show_more: function(evt) {
7 var self = this;
8- var ids = self.view.dataset.ids.splice(0);
9 return this.dataset.read_slice(this.view.fields_keys.concat(['__last_update']), {
10 'limit': self.view.limit,
11 'offset': self.dataset_offset += self.view.limit
12 }).then(function(records) {
13- self.view.dataset.ids = ids.concat(self.dataset.ids);
14 self.do_add_records(records);
15 self.compute_cards_auto_height();
16 self.view.postprocess_m2m_tags();

Subscribers

People subscribed via source and target branches