Merge lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web

[Ruchir Shukla(BizzAppDev)]

[Stefan Rijnhart (Opener) (stefan-opener)]

Ruchir, thanks for taking this dangling branch of Holger and propose it. I assume you have tested it thoroughly. To qualify for a merge in OCB, you need to prepare a branch that proposes the same change into upstream openerp-web. Setting to needs-fixing to indicate that this still needs to be done.

review: Needs Fixing

[Ruchir Shukla(BizzAppDev) (ruchir.shukla)]

Hello Stefan !

Yes I have tested this branch and it is solving the problem.

This bug is only effecting OCB branch because of changes from this (http://bazaar.launchpad.net/~ocb/ocb-web/7.0/revision/4040) commit .
And changes from this commit is not in openerp-web. So We do not have to provide any merge propose for openerp-web.

Please let me know your view on the same.

[Stefan Rijnhart (Opener) (stefan-opener)]

I see. In that case, there is a corresponding fix for upstream OpenERP, and you should propose the fix into the unmerged bugfixing branch then: https://code.launchpad.net/~openerp-dev/openerp-web/7.0-opw-596129-msh/+merge/180067

[Ruchir Shukla(BizzAppDev) (ruchir.shukla)]

Done.
https://code.launchpad.net/~ruchir.shukla/openerp-web/7.0-opw-596129-fix-destroy/+merge/217328

[Stefan Rijnhart (Opener) (stefan-opener)]

Thank you so much for your efforts!

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

I have tried and it works like intended.

Thanks for the fix.

Regards.

review: Approve (code review and test)

[Lara (Therp) (lfreeke)]

review: Approve (test)

[Holger Brunn (Therp) (hbrunn)]

https://github.com/OCA/OCB/pull/23

Unmerged revisions

4177. By Holger Brunn (Therp) on 2014-04-04

[FIX] form.destroy() doesn't clean up buttons area

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2014-04-18 09:20:33 +0000
+++ addons/web/static/src/js/view_form.js	2014-04-23 14:35:10 +0000
@@ -147,6 +147,9 @@
             this.$el.off('.formBlur');
         }
         this._super();
+        if (this.$buttons) {
+            this.$buttons.remove();
+        }
     },
     load_form: function(data) {
         var self = this;