Merge lp:~therp-nl/ocb-web/6.1-lp1066703_edition_form_is_undefined into lp:ocb-web/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 2515
Proposed branch: lp:~therp-nl/ocb-web/6.1-lp1066703_edition_form_is_undefined
Merge into: lp:ocb-web/6.1
Diff against target: 18 lines (+5/-3)
1 file modified
addons/web/static/src/js/view_list_editable.js (+5/-3)
To merge this branch: bzr merge lp:~therp-nl/ocb-web/6.1-lp1066703_edition_form_is_undefined
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+173904@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Do we really need line 11?

review: Needs Information
2515. By Stefan Rijnhart (Opener)

[RFR] Remove superfluous check

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I take that as a rethorical question ;-) As the experts say: No, because the base value is resolvable [1].

Thanks for pointing that out! Code adapted.

[1] http://stackoverflow.com/questions/9981104/why-does-an-undefined-variable-in-javascript-sometimes-evaluate-to-false-and-som

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_list_editable.js'
2--- addons/web/static/src/js/view_list_editable.js 2012-06-15 05:54:40 +0000
3+++ addons/web/static/src/js/view_list_editable.js 2013-07-15 13:48:24 +0000
4@@ -136,9 +136,11 @@
5 }
6 cancelled.then(function () {
7 self.view.unpad_columns();
8- self.edition_form.stop();
9- self.edition_form.$element.remove();
10- delete self.edition_form;
11+ if (self.edition_form) {
12+ self.edition_form.stop();
13+ self.edition_form.$element.remove();
14+ delete self.edition_form;
15+ }
16 self.dataset.index = null;
17 delete self.edition_id;
18 delete self.edition;

Subscribers

People subscribed via source and target branches