OpenERP Community Backports (Server)

Merge lp:~therp-nl/ocb-server/6.1_lp1188136 into lp:ocb-server/6.1

  1. 6.1_lp1188136
  2. Merge into 6.1
Proposed by Holger Brunn (Therp)
Status: Merged
Merged at revision: 4325
Proposed branch: lp:~therp-nl/ocb-server/6.1_lp1188136
Merge into: lp:ocb-server/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
openerp/report/render/rml2pdf/utils.py (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/ocb-server/6.1_lp1188136
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Christophe CHAUVET code review, no test Approve
Review via email: mp+190673@code.launchpad.net

Commit message

[FIX] don't stop iterating nodes after setTag

To post a comment you must log in.
Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Hi Holger

Thanks for the MP

It's ok for me

Regards,

review: Approve (code review, no test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/report/render/rml2pdf/utils.py'
2--- openerp/report/render/rml2pdf/utils.py 2012-01-24 12:55:12 +0000
3+++ openerp/report/render/rml2pdf/utils.py 2013-10-11 14:03:37 +0000
4@@ -102,7 +102,7 @@
5 n2.tag = tag
6 n2.attrib.update(attr or {})
7 yield n2
8- tagname = ''
9+ continue
10 except GeneratorExit:
11 pass
12 except Exception, e:

Subscribers

People subscribed via source and target branches

to status/vote changes: