Merge lp:~therp-nl/ocb-server/6.1-lp1431839_cannot_create_database into lp:ocb-server/6.1

Proposed by Ronald Portier (Therp)
Status: Merged
Merged at revision: 4332
Proposed branch: lp:~therp-nl/ocb-server/6.1-lp1431839_cannot_create_database
Merge into: lp:ocb-server/6.1
Diff against target: 15 lines (+3/-1)
1 file modified
openerp/addons/base/base.sql (+3/-1)
To merge this branch: bzr merge lp:~therp-nl/ocb-server/6.1-lp1431839_cannot_create_database
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+252892@code.launchpad.net

Description of the change

Needed after revision 4330 when creating new database.

Prevents crash of new database creation, because user is originally created with company_id = 1, while company database still completely empty.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

This happens also on upstream?

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

little remark: Filling in incomplete data here is okay because the real data is filled in in base.xml. And given that we're in init mode, also noupdate records (like main_company) are overwritten

review: Approve (code review)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

@Pedro I do not think it will happen upstream, as the offending revision (which by itself is a welcome improvement) is only on OCB.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

@Ronald, I understand. Thanks for the info.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/base.sql'
2--- openerp/addons/base/base.sql 2012-03-07 13:05:26 +0000
3+++ openerp/addons/base/base.sql 2015-03-13 13:04:31 +0000
4@@ -348,9 +348,11 @@
5 );
6
7 ---------------------------------
8--- Users
9+-- Company and Users
10 ---------------------------------
11
12+insert into res_company (id,name) values (1,'Your Company');
13+insert into ir_model_data (name,module,model,noupdate,res_id) values ('main_company','base','res.company',True,1);
14 insert into res_users (id,login,password,name,active,company_id,context_lang) values (1,'admin','admin','Administrator',True,1,'en_US');
15 insert into ir_model_data (name,module,model,noupdate,res_id) values ('user_root','base','res.users',True,1);
16

Subscribers

People subscribed via source and target branches

to status/vote changes: