Merge lp:~therp-nl/ocb-addons/7.0_lp1193779_internal_moves_not_created into lp:ocb-addons

[Ronald Portier (Therp)]

[Holger Brunn (Therp) (hbrunn)]

is this a workaround for the issue mentioned in https://bugs.launchpad.net/ocb-addons/+bug/1193779/comments/5 or do we genuinely need check_move() here?

review: Needs Information

[Christophe CHAUVET (christophe-chauvet)]

Hi Guys

Have you check my answer on the bug report https://bugs.launchpad.net/ocb-addons/+bug/1193779/comments/5

It fix the general issue with workflow engine, if you inherit transition to add your specific test case.

Regards,

[Mohammad Alhashash (alhashash)]

> is this a workaround for the issue mentioned in https://bugs.launchpad.net
> /ocb-addons/+bug/1193779/comments/5 or do we genuinely need check_move() here?

check_move() is required. order_by is not required as per the mentioned comment as workflow transitions should be deterministic and not dependent on the order of evaluation.

BTW, the branch is now committed into official 7.0

[Stefan Rijnhart (Opener) (stefan-opener)]

Thank you Mohammed for your work and for the clarification! Setting this MP to rejected because the patches has been adopted in official 7.0.

Unmerged revisions

9511. By alhashash on 2013-09-18

[FIX] Fixes lp1193779 - Pull flows do not create procurement internal moves

    Backport of fix proposed by Mohammed Alhashash for openobject-addons.

=== modified file 'procurement/procurement_workflow.xml'
--- procurement/procurement_workflow.xml	2012-10-23 16:05:04 +0000
+++ procurement/procurement_workflow.xml	2013-09-18 11:33:27 +0000
@@ -153,7 +153,7 @@
             -->
             <field name="act_from" ref="act_confirm_mto"/>
             <field name="act_to" ref="act_make_done"/>
-            <field name="condition">not check_produce() and not check_buy()</field>
+            <field name="condition">not check_produce() and not check_buy() and not check_move()</field>
         </record>
 
         <record id="trans_make_to_stock_make_done" model="workflow.transition">