Merge lp:~therp-nl/ocb-addons/6.1_lp1172293 into lp:ocb-addons/6.1

Proposed by Holger Brunn (Therp)
Status: Merged
Merged at revision: 6734
Proposed branch: lp:~therp-nl/ocb-addons/6.1_lp1172293
Merge into: lp:ocb-addons/6.1
Diff against target: 32 lines (+3/-3)
2 files modified
account_payment/account_move_line.py (+2/-2)
account_payment/account_payment_view.xml (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/ocb-addons/6.1_lp1172293
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Holger Brunn (Therp) Needs Resubmitting
Review via email: mp+160659@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Is this the whole fix or do you still need to set the all_fiscalyear value in the context of the view?

review: Needs Fixing
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Yes, we need to fix this in the payment order's form too. But this button gets replaced by account_banking, so I'll propose a fix for this one too

review: Needs Resubmitting
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for the change!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_payment/account_move_line.py'
2--- account_payment/account_move_line.py 2011-07-01 23:41:24 +0000
3+++ account_payment/account_move_line.py 2013-04-25 08:11:26 +0000
4@@ -51,7 +51,7 @@
5 if not args:
6 return []
7 line_obj = self.pool.get('account.move.line')
8- query = line_obj._query_get(cr, uid, context={})
9+ query = line_obj._query_get(cr, uid, context=context)
10 where = ' and '.join(map(lambda x: '''(SELECT
11 CASE WHEN l.amount_currency < 0
12 THEN - l.amount_currency
13@@ -117,4 +117,4 @@
14
15 account_move_line()
16
17-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
18\ No newline at end of file
19+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
20
21=== modified file 'account_payment/account_payment_view.xml'
22--- account_payment/account_payment_view.xml 2012-01-31 13:36:57 +0000
23+++ account_payment/account_payment_view.xml 2013-04-25 08:11:26 +0000
24@@ -107,7 +107,7 @@
25 <field name="user_id"/>
26 <field name="date_prefered"/>
27 <field name="date_scheduled" select="1" attrs="{'readonly':[('date_prefered','!=','fixed')]}" />
28- <button colspan="2" name="%(action_create_payment_order)d" string="Select Invoices to Pay" type="action" attrs="{'invisible':[('state','=','done')]}" icon="gtk-find"/>
29+ <button colspan="2" name="%(action_create_payment_order)d" string="Select Invoices to Pay" type="action" attrs="{'invisible':[('state','=','done')]}" context="{'all_fiscalyear': True}" icon="gtk-find"/>
30 <field name="company_id" widget='selection' groups="base.group_multi_company"/>
31 </group>
32 <field name="line_ids" colspan="4" widget="one2many_list" nolabel="1" context="{'order_id': active_id or False}" >

Subscribers

People subscribed via source and target branches