Merge lp:~therp-nl/banking-addons/camt_stuzza into lp:banking-addons

[Holger Brunn (Therp)]

I've been working on a camt53 statement provided by UniCredit Austria.

I encountered a weird namespace there and needed the following patch. See the first commit message for some details. The full namespace would be 'ISO:camt.053.001.02:APC:STUZZA:payments:003'.

Now I feel a bit uneasy about doing startswith heuristics. Why don't we whitelist namespaces we can work with?

[Holger Brunn (Therp) (hbrunn)]

Stuzza btw. is the Austrian payment provider handling this stuff for UniCredit, so I assume this path will be necessary for some other Austrian banks too.

[Pedro Manuel Baeza (pedro.baeza)]

Seeing XSD, it seems OK, although I have no opportunity to test in a real scenario.

Regards.

review: Approve (code review)

[Stefan Rijnhart (Opener) (stefan-opener)]

LGTM. I hope there are not a lot of other alternative namespaces around.

review: Approve

[Stefan Rijnhart (Opener) (stefan-opener)]

BTW yes I would prefer a whitelist like you suggest in the proposal description.

[Holger Brunn (Therp) (hbrunn)]

So the xsd says: 'All XML data validating with this scheme can also be validated with the underlying original namespace of ISO. Therefor [sic] the original ISO namespace is to be used for data transmission.'
Which means UniCredit does it wrong. But well, that's how they hand out the files, and I think for the time being we need to deal with that.

[Stefan Rijnhart (Opener) (stefan-opener)]

Are you still going to refactor into a whitelist, or do you want me to merge this for now?

review: Needs Information

[Holger Brunn (Therp) (hbrunn)]

Given that I have no overview about the deviations floating around, I wouldn't dare to introduce a hard (=full namespace) whitelist. So I'd propose to merge as it is.

[Stefan Rijnhart (Opener) (stefan-opener)]

Done!

review: Approve

=== modified file 'account_banking_camt/camt.py'
--- account_banking_camt/camt.py	2013-10-11 12:20:14 +0000
+++ account_banking_camt/camt.py	2014-03-20 14:33:15 +0000
@@ -253,12 +253,14 @@
         """
         Sanity check the document's namespace
         """
-        if not self.ns.startswith('{urn:iso:std:iso:20022:tech:xsd:camt.'):
+        if not self.ns.startswith('{urn:iso:std:iso:20022:tech:xsd:camt.')\
+           and not self.ns.startswith('{ISO:camt.'):
             raise except_orm(
                 "Error",
                 "This does not seem to be a CAMT format bank statement.")
 
-        if not self.ns.startswith('{urn:iso:std:iso:20022:tech:xsd:camt.053.'):
+        if not self.ns.startswith('{urn:iso:std:iso:20022:tech:xsd:camt.053.')\
+           and not self.ns.startswith('{ISO:camt.053'):
             raise except_orm(
                 "Error",
                 "Only CAMT.053 is supported at the moment.")