Banking Addons

Merge lp:~therp-nl/banking-addons/ba70-lp1296789-remove_static into lp:banking-addons

  1. ba70-lp1296789-remove_static
  2. Merge into banking-addons-70
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 242
Proposed branch: lp:~therp-nl/banking-addons/ba70-lp1296789-remove_static
Merge into: lp:banking-addons
Diff against target: 10 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba70-lp1296789-remove_static
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Holger Brunn (Therp) Approve
Review via email: mp+212502@code.launchpad.net

Description of the change

Parsers are made available in the bank statement import screen when the module containing the parser is loaded. Of course, having a static directory causes the module to be loaded in the first place. This causes the parsers in these modules to show up in every installation of banking-addons.

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I see current method of adding parsers is a little twisted, but if there is no other solution, go ahead with the patch.

Have you seen method used on account_statement_base_import?

Regards.

review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for the review, Pedro! Yes, I have seen it and it does not have the disadvantages of the account_banking one so it will be refactored eventually. First priority however is to split off the account_banking import mechanism from the reconciliation part and make the statements that it generates compatible with account_statement_reconcile.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed directory 'account_banking_mt940/static'
2=== removed directory 'account_banking_mt940/static/src'
3=== removed directory 'account_banking_mt940/static/src/img'
4=== removed file 'account_banking_mt940/static/src/img/icon.png'
5Binary files account_banking_mt940/static/src/img/icon.png 2014-03-06 14:05:01 +0000 and account_banking_mt940/static/src/img/icon.png 1970-01-01 00:00:00 +0000 differ
6=== removed directory 'account_banking_nl_ing_mt940/static'
7=== removed directory 'account_banking_nl_ing_mt940/static/src'
8=== removed directory 'account_banking_nl_ing_mt940/static/src/img'
9=== removed file 'account_banking_nl_ing_mt940/static/src/img/icon.png'
10Binary files account_banking_nl_ing_mt940/static/src/img/icon.png 2014-03-06 14:05:01 +0000 and account_banking_nl_ing_mt940/static/src/img/icon.png 1970-01-01 00:00:00 +0000 differ

Subscribers

People subscribed via source and target branches

to status/vote changes: