Merge lp:~therp-nl/banking-addons/ba70-bank_statement_order into lp:banking-addons

[Stefan Rijnhart (Opener)]

[Pedro Manuel Baeza (pedro.baeza)]

Of course!

review: Approve

[Stéphane Bidoul (Acsone) (sbi)]

A couple of line above, there is this comment "4. Ordering is based on auto generated id."
I suppose it should be suppressed too.

[lp:~therp-nl/banking-addons/ba70-bank_statement_order]

187. By Stefan Rijnhart (Opener) on 2013-09-06

[RFR] Update class doc

[Stefan Rijnhart (Opener) (stefan-opener)]

@stéphane good catch. Doc updated

[Pedro Manuel Baeza (pedro.baeza)]

Stefan, why the dashes in the middle of the sentence?

[Stéphane Bidoul (Acsone) (sbi)]

review: Approve (code review)

[Stefan Rijnhart (Opener) (stefan-opener)]

I'm using it as a marker for an unordered list. Not sure if it renders correctly but given the lack of documentation in general there is no meaningful way to render a set of useful docs from these modules anyway.

[Pedro Manuel Baeza (pedro.baeza)]

Yeah, I mean this:

"- upon confirmation of a statement line"

This seems to be the continuation of the previous line ("Move lines are"), and you have put a leading dash, but don't worry, it's not too much important.

[Stefan Rijnhart (Opener) (stefan-opener)]

Sorry Pedro, had not noticed the particular error. Fixed it and improved the docs even more.

[lp:~therp-nl/banking-addons/ba70-bank_statement_order]

188. By Stefan Rijnhart (Opener) on 2013-09-09

[RFR] Improved doc

[Pedro Manuel Baeza (pedro.baeza)]

review: Approve

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

=== modified file 'account_banking/account_banking.py'
--- account_banking/account_banking.py	2013-06-25 15:40:51 +0000
+++ account_banking/account_banking.py	2013-09-09 09:23:25 +0000
@@ -274,17 +274,18 @@
 
 class account_bank_statement(orm.Model):
     '''
-    Extensions from account_bank_statement:
-        1. Removed period_id (transformed to optional boolean) - as it is no
-           longer needed.
-           NB! because of #1. changes required to account_voucher!
-        2. Extended 'button_confirm' trigger to cope with the period per
-           statement_line situation.
-        3. Added optional relation with imported statements file
-        4. Ordering is based on auto generated id.
+    Implement changes to this model for the following features:
+
+    * bank statement lines have their own period_id, derived from
+    their effective date. The period and date are propagated to
+    the move lines created from each statement line
+    * bank statement lines have their own state. When a statement
+    is confirmed, all lines are confirmed too. When a statement
+    is reopened, lines remain confirmed until reopened individually.
+    * upon confirmation of a statement line, the move line is
+    created and reconciled according to the matched entry(/ies)
     '''
     _inherit = 'account.bank.statement'
-    _order = 'id'
 
     _columns = {
         'period_id': fields.many2one('account.period', 'Period',