Banking Addons

Merge lp:~therp-nl/banking-addons/ba70-IE_BBAN_format into lp:banking-addons

  1. ba70-IE_BBAN_format
  2. Merge into banking-addons-70
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 196
Proposed branch: lp:~therp-nl/banking-addons/ba70-IE_BBAN_format
Merge into: lp:banking-addons
Diff against target: 12 lines (+1/-1)
1 file modified
account_banking/sepa/iban.py (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba70-IE_BBAN_format
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Review via email: mp+187799@code.launchpad.net

Description of the change

IE IBAN format for BBAN extraction is too long. Compare format specification on Wikipedia [1] and sample account IE29AIBK93115212345678

6.1 version here: https://code.launchpad.net/~therp-nl/banking-addons/ba61-IE_BBAN_format

[1] http://en.wikipedia.org/wiki/International_Bank_Account_Number#IBAN_formats_by_country

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/sepa/iban.py'
2--- account_banking/sepa/iban.py 2013-04-15 13:59:50 +0000
3+++ account_banking/sepa/iban.py 2013-09-26 14:28:25 +0000
4@@ -214,7 +214,7 @@
5 'GR': BBANFormat('BBBCCCCAAAAAAAAAAAAAAAA', '%B-%C-%A', nolz=True),
6 'HR': BBANFormat('BBBBBBBAAAAAAAAAA', '%B-%A'),
7 'HU': BBANFormat('BBBCCCCXAAAAAAAAAAAAAAAV', '%B%C%X %A%V'),
8- 'IE': BBANFormat('BBBBCCCCCCAAAAAAAAV', '%C %A%V'),
9+ 'IE': BBANFormat('BBBBCCCCCCAAAAAAAA', '%C %A'),
10 'IL': BBANFormat('BBBCCCAAAAAAAAAAAAA', '%C%A'),
11 # Iceland uses an extra identification number, split in two on
12 # display. Coded here as %P%V.

Subscribers

People subscribed via source and target branches

to status/vote changes: