Banking Addons

Merge lp:~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban into lp:banking-addons

  1. ba61-lp1131200-do_not_overwrite_iban_with_bban
  2. Merge into banking-addons-70
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 162
Merged at revision: 164
Proposed branch: lp:~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban
Merge into: lp:banking-addons
Diff against target: 21 lines (+1/-4)
1 file modified
account_banking/account_banking.py (+1/-4)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review, no test Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+154490@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/account_banking.py'
2--- account_banking/account_banking.py 2013-01-30 11:34:58 +0000
3+++ account_banking/account_banking.py 2013-03-20 19:34:23 +0000
4@@ -1520,16 +1520,13 @@
5 if country.code in sepa.IBAN.countries:
6 acc_number_fmt = sepa.BBAN(acc_number, country.code)
7 if acc_number_fmt.valid:
8- values['acc_number'] = str(acc_number_fmt)
9+ values['acc_number_domestic'] = str(acc_number_fmt)
10 else:
11- values['acc_number'] = acc_number
12 result.update(warning(
13 _('Invalid format'),
14 _('The account number has the wrong format for %(country)s')
15 % {'country': country.name}
16 ))
17- else:
18- values['acc_number'] = acc_number
19 return result
20
21 def onchange_iban(

Subscribers

People subscribed via source and target branches

to status/vote changes: