Merge lp:~therp-nl/banking-addons/ba61-fix_triodos_iban_bic_split into lp:banking-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 170
Proposed branch: lp:~therp-nl/banking-addons/ba61-fix_triodos_iban_bic_split
Merge into: lp:banking-addons/6.1
Diff against target: 32 lines (+8/-2)
2 files modified
account_banking_nl_triodos/__openerp__.py (+1/-1)
account_banking_nl_triodos/triodos.py (+7/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba61-fix_triodos_iban_bic_split
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Review via email: mp+164644@code.launchpad.net
To post a comment you must log in.
168. By Stefan Rijnhart (Opener)

[FIX] Split off BIC part from IBAN in Triodos statements

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_nl_triodos/__openerp__.py'
2--- account_banking_nl_triodos/__openerp__.py 2011-12-27 12:00:52 +0000
3+++ account_banking_nl_triodos/__openerp__.py 2013-05-19 20:39:26 +0000
4@@ -27,7 +27,7 @@
5 ##############################################################################
6 {
7 'name': 'Triodos (NL) Bank Statements Import',
8- 'version': '0.92',
9+ 'version': '0.168',
10 'license': 'GPL-3',
11 'author': 'Therp BV / EduSense BV',
12 'website': 'https://launchpad.net/account-banking',
13
14=== modified file 'account_banking_nl_triodos/triodos.py'
15--- account_banking_nl_triodos/triodos.py 2012-01-17 08:48:10 +0000
16+++ account_banking_nl_triodos/triodos.py 2013-05-19 20:39:26 +0000
17@@ -151,8 +151,14 @@
18 def parse_message(self):
19 '''
20 Parse structured message parts into appropriate attributes.
21- No processing done here for Triodos, maybe later.
22 '''
23+ # IBAN accounts are prefixed by BIC
24+ if self.remote_account:
25+ parts = self.remote_account.split(' ')
26+ if len(parts) == 2:
27+ self.remote_bank_bic = parts[0]
28+ self.remote_account = parts[1]
29+
30
31 class statement(models.mem_bank_statement):
32 '''

Subscribers

People subscribed via source and target branches