Merge lp:~therp-nl/banking-addons/ba61-company_filter_on_transfer_settings into lp:banking-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 158
Proposed branch: lp:~therp-nl/banking-addons/ba61-company_filter_on_transfer_settings
Merge into: lp:banking-addons/6.1
Diff against target: 32 lines (+9/-2)
2 files modified
account_direct_debit/model/account_payment.py (+1/-0)
account_direct_debit/view/account_payment.xml (+8/-2)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba61-company_filter_on_transfer_settings
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp no test, code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+144083@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (no test, review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Seems fine to me

review: Approve (no test, code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_direct_debit/model/account_payment.py'
2--- account_direct_debit/model/account_payment.py 2012-05-01 20:36:44 +0000
3+++ account_direct_debit/model/account_payment.py 2013-01-21 11:33:19 +0000
4@@ -447,6 +447,7 @@
5 ('account_id.type', '=', 'payable'),
6 ('amount_to_pay', '>', 0)
7 ]
8+ domain.append(('company_id', '=', payment.mode.company_id.id))
9 # apply payment term filter
10 if payment.mode.payment_term_ids:
11 domain = domain + [
12
13=== modified file 'account_direct_debit/view/account_payment.xml'
14--- account_direct_debit/view/account_payment.xml 2012-04-14 08:58:58 +0000
15+++ account_direct_debit/view/account_payment.xml 2013-01-21 11:33:19 +0000
16@@ -63,8 +63,14 @@
17 <field name="type">form</field>
18 <field name="arch" type="xml">
19 <field name="type" position="after">
20- <field name="transfer_account_id"/>
21- <field name="transfer_journal_id"/>
22+ <field name="transfer_account_id"
23+ domain="[('type', '=', 'other'),
24+ ('reconcile', '=', True),
25+ ('company_id', '=', company_id)]"
26+ />
27+ <field name="transfer_journal_id"
28+ domain="[('company_id', '=', company_id)]"
29+ />
30 <field name="payment_term_ids"/>
31 </field>
32 </field>

Subscribers

People subscribed via source and target branches