Banking Addons

Merge lp:~therp-nl/banking-addons/ba61-clieop_amount_should_be_integer into lp:banking-addons/6.1

  1. ba61-clieop_amount_should_be_integer
  2. Merge into 6.1
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 155
Proposed branch: lp:~therp-nl/banking-addons/ba61-clieop_amount_should_be_integer
Merge into: lp:banking-addons/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
account_banking_nl_clieop/wizard/clieop.py (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba61-clieop_amount_should_be_integer
Reviewer Review Type Date Requested Status
Niels Huylebroeck Approve
Review via email: mp+143124@code.launchpad.net

Description of the change

Previous fix for lp:1098699 should return an integer

To post a comment you must log in.
Revision history for this message
Niels Huylebroeck (red15) wrote :

For those not familiar with this sort of operations, most banks require you to pay in cents, this way they avoid any of the trouble with decimal separators and decimal precision.

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_nl_clieop/wizard/clieop.py'
2--- account_banking_nl_clieop/wizard/clieop.py 2013-01-11 19:42:19 +0000
3+++ account_banking_nl_clieop/wizard/clieop.py 2013-01-14 15:29:23 +0000
4@@ -278,7 +278,7 @@
5 self.transaction.transactiontype = type_
6 self.transaction.accountno_beneficiary = accountno_beneficiary
7 self.transaction.accountno_payer = accountno_payer
8- self.transaction.amount = round(amount * 100)
9+ self.transaction.amount = int(round(amount * 100))
10 if reference:
11 self.paymentreference.paymentreference = reference
12 # Allow long message lines to redistribute over multiple message

Subscribers

People subscribed via source and target branches