Banking Addons

Merge lp:~therp-nl/banking-addons/ba61-SCT_suitable_bank_types into lp:banking-addons/6.1

  1. ba61-SCT_suitable_bank_types
  2. Merge into 6.1
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 184
Proposed branch: lp:~therp-nl/banking-addons/ba61-SCT_suitable_bank_types
Merge into: lp:banking-addons/6.1
Diff against target: 33 lines (+6/-3)
1 file modified
account_banking_sepa_credit_transfer/data/payment_type_sepa_sct.xml (+6/-3)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba61-SCT_suitable_bank_types
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Review via email: mp+187027@code.launchpad.net

Description of the change

Because there is no suitable bank type missing for SCT, if I create a payment with a payment mode of this type no bank account is selected on the payment order.

I injected this change when I ported the SCT module to 7.0, but I forgot to submit a fix to the 6.1 branch back then. So this code is already present in 7.0.

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_sepa_credit_transfer/data/payment_type_sepa_sct.xml'
2--- account_banking_sepa_credit_transfer/data/payment_type_sepa_sct.xml 2013-05-15 20:09:21 +0000
3+++ account_banking_sepa_credit_transfer/data/payment_type_sepa_sct.xml 2013-09-23 13:46:19 +0000
4@@ -7,7 +7,8 @@
5 <record id="export_sepa_sct_001_001_04" model="payment.mode.type">
6 <field name="name">SEPA Credit Transfer v04</field>
7 <field name="code">pain.001.001.04</field>
8- <field name="suitable_bank_types"></field>
9+ <field name="suitable_bank_types"
10+ eval="[(6,0,[ref('base_iban.bank_iban')])]" />
11 <field name="ir_model_id" ref="model_banking_export_sepa_wizard"/>
12 <field name="payment_order_type">payment</field>
13 </record>
14@@ -15,7 +16,8 @@
15 <record id="export_sepa_sct_001_001_03" model="payment.mode.type">
16 <field name="name">SEPA Credit Transfer v03</field>
17 <field name="code">pain.001.001.03</field>
18- <field name="suitable_bank_types"></field>
19+ <field name="suitable_bank_types"
20+ eval="[(6,0,[ref('base_iban.bank_iban')])]" />
21 <field name="ir_model_id" ref="model_banking_export_sepa_wizard"/>
22 <field name="payment_order_type">payment</field>
23 </record>
24@@ -23,7 +25,8 @@
25 <record id="export_sepa_sct_001_001_02" model="payment.mode.type">
26 <field name="name">SEPA Credit Transfer v02</field>
27 <field name="code">pain.001.001.02</field>
28- <field name="suitable_bank_types"></field>
29+ <field name="suitable_bank_types"
30+ eval="[(6,0,[ref('base_iban.bank_iban')])]" />
31 <field name="ir_model_id" ref="model_banking_export_sepa_wizard"/>
32 <field name="payment_order_type">payment</field>
33 </record>

Subscribers

People subscribed via source and target branches