Merge lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures into lp:banking-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 166
Proposed branch: lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures
Merge into: lp:banking-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
account_banking/banking_import_transaction.py (+2/-2)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp nitpickings Approve
Ronald Portier (Therp) Approve
Review via email: mp+161095@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

LGTM. No Test

review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (nitpickings)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py 2013-03-21 13:27:19 +0000
+++ account_banking/banking_import_transaction.py 2013-04-26 11:28:32 +0000
@@ -222,7 +222,7 @@
222 Match on ID of invoice (reference, name or number, whatever222 Match on ID of invoice (reference, name or number, whatever
223 available and sensible)223 available and sensible)
224 '''224 '''
225 if invoice.reference:225 if invoice.reference and len(invoice.reference) > 2:
226 # Reference always comes first, as it is manually set for a226 # Reference always comes first, as it is manually set for a
227 # reason.227 # reason.
228 iref = invoice.reference.upper()228 iref = invoice.reference.upper()
@@ -230,7 +230,7 @@
230 return True230 return True
231 if invoice.type.startswith('in_'):231 if invoice.type.startswith('in_'):
232 # Internal numbering, no likely match on number232 # Internal numbering, no likely match on number
233 if invoice.name:233 if invoice.name and len(invoice.name) > 2:
234 iname = invoice.name.upper()234 iname = invoice.name.upper()
235 if iname in ref or iname in msg:235 if iname in ref or iname in msg:
236 return True236 return True

Subscribers

People subscribed via source and target branches