Merge lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures into lp:banking-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 166
Proposed branch: lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures
Merge into: lp:banking-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
account_banking/banking_import_transaction.py (+2/-2)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp nitpickings Approve
Ronald Portier (Therp) Approve
Review via email: mp+161095@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

LGTM. No Test

review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (nitpickings)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/banking_import_transaction.py'
2--- account_banking/banking_import_transaction.py 2013-03-21 13:27:19 +0000
3+++ account_banking/banking_import_transaction.py 2013-04-26 11:28:32 +0000
4@@ -222,7 +222,7 @@
5 Match on ID of invoice (reference, name or number, whatever
6 available and sensible)
7 '''
8- if invoice.reference:
9+ if invoice.reference and len(invoice.reference) > 2:
10 # Reference always comes first, as it is manually set for a
11 # reason.
12 iref = invoice.reference.upper()
13@@ -230,7 +230,7 @@
14 return True
15 if invoice.type.startswith('in_'):
16 # Internal numbering, no likely match on number
17- if invoice.name:
18+ if invoice.name and len(invoice.name) > 2:
19 iname = invoice.name.upper()
20 if iname in ref or iname in msg:
21 return True

Subscribers

People subscribed via source and target branches