Banking Addons

Merge lp:~therp-nl/banking-addons/7.0-ing_mt940_update into lp:banking-addons

  1. 7.0-ing_mt940_update
  2. Merge into banking-addons-70
Proposed by Holger Brunn (Therp)
Status: Merged
Merged at revision: 260
Proposed branch: lp:~therp-nl/banking-addons/7.0-ing_mt940_update
Merge into: lp:banking-addons
Diff against target: 26 lines (+8/-1)
1 file modified
account_banking_nl_ing_mt940/account_banking_nl_ing_mt940.py (+8/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/7.0-ing_mt940_update
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+222596@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

LGTM

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I don't know about MT940, but changes are correct sintactically, and I see here that the code CNTP is used for SEPA:

https://www.ing.be/SiteCollectionDocuments/ImpactSEPA_EN.pdf

Regards.

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_nl_ing_mt940/account_banking_nl_ing_mt940.py'
2--- account_banking_nl_ing_mt940/account_banking_nl_ing_mt940.py 2014-05-12 08:57:10 +0000
3+++ account_banking_nl_ing_mt940/account_banking_nl_ing_mt940.py 2014-06-10 07:56:32 +0000
4@@ -62,7 +62,8 @@
5 return
6 super(IngMT940Parser, self).handle_tag_86(cr, data)
7 codewords = ['RTRN', 'BENM', 'ORDP', 'CSID', 'BUSP', 'MARF', 'EREF',
8- 'PREF', 'REMI', 'ID', 'PURP', 'ULTB', 'ULTD']
9+ 'PREF', 'REMI', 'ID', 'PURP', 'ULTB', 'ULTD',
10+ 'CREF', 'IREF', 'CNTP', 'ULTC', 'EXCH', 'CHGS']
11 subfields = {}
12 current_codeword = None
13 for word in data.split('/'):
14@@ -75,6 +76,12 @@
15 if current_codeword in subfields:
16 subfields[current_codeword].append(word)
17
18+ if 'CNTP' in subfields:
19+ self.current_transaction.remote_account = subfields['CNTP'][0]
20+ self.current_transaction.remote_bank_bic = subfields['CNTP'][1]
21+ self.current_transaction.remote_owner = subfields['CNTP'][2]
22+ self.current_transaction.remote_owner_city = subfields['CNTP'][3]
23+
24 if 'BENM' in subfields:
25 self.current_transaction.remote_account = subfields['BENM'][0]
26 self.current_transaction.remote_bank_bic = subfields['BENM'][1]

Subscribers

People subscribed via source and target branches

to status/vote changes: