Merge lp:~therp-nl/banking-addons/6.1_mt940_line_endings into lp:banking-addons/6.1

Proposed by Holger Brunn (Therp) on 2014-06-19
Status: Merged
Merged at revision: 197
Proposed branch: lp:~therp-nl/banking-addons/6.1_mt940_line_endings
Merge into: lp:banking-addons/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
account_banking_mt940/mt940.py (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/6.1_mt940_line_endings
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve on 2014-06-25
Pedro Manuel Baeza code review 2014-06-19 Approve on 2014-06-19
Review via email: mp+223755@code.launchpad.net
To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

Regards.

review: Approve (code review)

Tnx!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_mt940/mt940.py'
2--- account_banking_mt940/mt940.py 2014-02-28 10:54:35 +0000
3+++ account_banking_mt940/mt940.py 2014-06-19 14:15:32 +0000
4@@ -75,7 +75,7 @@
5
6 def parse(self, cr, data):
7 'implements account_banking.parsers.models.parser.parse()'
8- iterator = data.split('\r\n').__iter__()
9+ iterator = data.replace('\r\n', '\n').split('\n').__iter__()
10 line = None
11 record_line = ''
12 try:

Subscribers

People subscribed via source and target branches