Code review comment for lp:~therp-nl/banking-addons/6.1_lp1176783
Revision history for this message
| Holger Brunn (Therp) (hbrunn) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
This would indeed fix the problem at hand.
But if match_type's semantics is 'I have exclusively matches of type $match_type', then all the code in this function is broken. Adhering to the maxim of only fixing the bug in bug fixes, I pushed the necessary fix to lp:~therp-nl/banking-addons/6.1_fix__get_move_info_semantics - this will fix my problem en passant.
So if you confirm that's the right semantics, we can ditch this MP and I'll propose the branch mentioned above.