Code review comment for lp:~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
review:
Needs Fixing
© 2004-2023
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
620cd52
(Get the code!)
Ronald,
thank you for the refactoring. I am very happy with the current algoritm. Sorry to bother you one more time, but I just have a hard time figuring out what 've' stands for. Using descriptive variables is almost always a good idea. Can you replace this variable name with something that is immediately clear? Please relace 'si' and 'ei' too, even though I managed to figure those out.