Merge lp:~therp-nl/banking-addons/6.1-undefined_variables_ref_msg into lp:banking-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 192
Merged at revision: 192
Proposed branch: lp:~therp-nl/banking-addons/6.1-undefined_variables_ref_msg
Merge into: lp:banking-addons/6.1
Diff against target: 15 lines (+2/-2)
1 file modified
account_banking/ (+2/-2)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/6.1-undefined_variables_ref_msg
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza code review Approve
Review via email:

Description of the change

A recent change revealed a bug in a code path that was never reached before, in which two variables are referenced that are not available in that code path.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) :
review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/'
2--- account_banking/ 2014-01-06 11:56:31 +0000
3+++ account_banking/ 2014-01-11 16:11:28 +0000
4@@ -296,9 +296,9 @@
5 # creation. This also enables us to search for the invoice number in the
6 # reference instead of the other way around, as most human interventions
7 # *add* text.
8+ ref = trans.reference.upper()
9+ msg = trans.message.upper()
10 if len(candidates) > 1 or not candidates:
11- ref = trans.reference.upper()
12- msg = trans.message.upper()
13 # The manual usage of the sales journal creates moves that
14 # are not tied to invoices. Thanks to Stefan Rijnhart for
15 # reporting this.


People subscribed via source and target branches