Merge lp:~therp-nl/banking-addons/6.1-lp933472-bic-not-required into lp:banking-addons/6.1

Proposed by Holger Brunn (Therp)
Status: Work in progress
Proposed branch: lp:~therp-nl/banking-addons/6.1-lp933472-bic-not-required
Merge into: lp:banking-addons/6.1
Diff against target: 20 lines (+6/-0)
1 file modified
account_banking/account_banking.py (+6/-0)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/6.1-lp933472-bic-not-required
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Needs Fixing
Review via email: mp+109842@code.launchpad.net
To post a comment you must log in.
138. By Holger Brunn (Therp)

[FIX] (account_banking) overriden _check_bank method in res_partner_bank
was not actually called

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Needs refactoring into a separate module, as the BIC requirement will be dropped in various countries at various times. E.g. for most Dutch banks, the requirement will be dropped in februari 2013.

review: Needs Fixing

Unmerged revisions

138. By Holger Brunn (Therp)

[FIX] (account_banking) overriden _check_bank method in res_partner_bank
was not actually called

137. By Holger Brunn (Therp)

[FIX] lp:933472 suppress base_iban's constraint to enforce BICs for IBANs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/account_banking.py'
2--- account_banking/account_banking.py 2012-05-02 15:09:49 +0000
3+++ account_banking/account_banking.py 2012-06-14 07:30:26 +0000
4@@ -1511,10 +1511,16 @@
5 _("The IBAN number doesn't seem to be correct")
6 )
7
8+ def _check_bank(self, cr, uid, ids, context=None):
9+ #suppress base_iban's constraint to enforce BICs for IBANs
10+ #workaround for lp:933472
11+ return True
12+
13 _constraints = [
14 # Cannot have this as a constraint as it is rejecting valid numbers from GB and DE
15 # It works much better without this constraint!
16 #(check_iban, _("The IBAN number doesn't seem to be correct"), ["acc_number"])
17+ (_check_bank, '\nPlease define BIC/Swift code on bank for bank type IBAN Account to make valid payments', ['bic'])
18 ]
19
20 res_partner_bank()

Subscribers

People subscribed via source and target branches