Merge lp:~therp-nl/banking-addons/6.1-fix_post_date_vs_value_date_confusion into lp:banking-addons/6.1
Status: | Merged |
---|---|
Approved by: | Guewen Baconnier @ Camptocamp |
Approved revision: | 193 |
Merged at revision: | 193 |
Proposed branch: | lp:~therp-nl/banking-addons/6.1-fix_post_date_vs_value_date_confusion |
Merge into: | lp:banking-addons/6.1 |
Diff against target: |
115 lines (+12/-12) 5 files modified
account_banking/banking_import_transaction.py (+6/-6) account_banking/parsers/models.py (+2/-2) account_banking_nl_abnamro/abnamro.py (+2/-2) account_banking_nl_ing/ing.py (+1/-1) account_banking_nl_triodos/triodos.py (+1/-1) |
To merge this branch: | bzr merge lp:~therp-nl/banking-addons/6.1-fix_post_date_vs_value_date_confusion |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Holger Brunn (Therp) | code review | Approve | |
Yannick Vaucher @ Camptocamp | code review, no tests | Approve | |
Review via email: mp+206684@code.launchpad.net |
Description of the change
Disambiguate the terminology concerning post date and value date. The only import filter that distinguished both dates was HBSC, which assigned value date to 'effective_date'. The recent CAMT filter copied this behaviour but as it turns out, the meaning of the value date (or rather the post date) was not honoured in processing the statement lines.
This branch implements using the post date for basically everything: statement line date, base date for determining statement reference, lookup of reconcilable items.
A more extensive fix for 7.0, which also takes care of the clarification in column names and titles is here: https:/
LGTM Thanks