Merge lp:~therp-nl/banking-addons/6.1-dev-useful_defaults into lp:banking-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merge reported by: Stefan Rijnhart (Opener)
Merged at revision: not available
Proposed branch: lp:~therp-nl/banking-addons/6.1-dev-useful_defaults
Merge into: lp:banking-addons/6.1
Prerequisite: lp:~therp-nl/banking-addons/6.1-dev-fixes_from_testing_iteration_2
Diff against target: 107 lines (+47/-5)
4 files modified
account_banking/account_banking.py (+39/-3)
account_banking/i18n/nl.po (+1/-1)
account_banking/wizard/bank_import.py (+5/-0)
account_banking/wizard/bank_import_view.xml (+2/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/6.1-dev-useful_defaults
Reviewer Review Type Date Requested Status
Banking Addons Core Editors Pending
Review via email: mp+104542@code.launchpad.net

This proposal supersedes a proposal from 2012-05-02.

Description of the change

This branch adds a number of useful defaults, such as the ones discussed in lp:931395

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/account_banking.py'
2--- account_banking/account_banking.py 2012-05-02 13:23:51 +0000
3+++ account_banking/account_banking.py 2012-05-03 12:17:23 +0000
4@@ -131,9 +131,41 @@
5 user = self.pool.get('res.users').browse(cursor, uid, uid, context=context)
6 if user.company_id:
7 return user.company_id.id
8- return self.pool.get('res.company').search(cursor, uid,
9- [('parent_id', '=', False)]
10- )[0]
11+ company_ids = self.pool.get('res.company').search(
12+ cursor, uid, [('parent_id', '=', False)])
13+ return len(company_ids) == 1 and company_ids[0] or False
14+
15+ def _default_journal(self, cr, uid, context=None):
16+ domain = [('type', '=', 'bank')]
17+ user = self.pool.get('res.users').read(
18+ cr, uid, uid, ['company_id'], context=context)
19+ if user['company_id']:
20+ domain.append(('company_id', '=', user['company_id'][0]))
21+ journal_ids = self.pool.get('account.journal').search(
22+ cr, uid, domain)
23+ return len(journal_ids) == 1 and journal_ids[0] or False
24+
25+ def _default_partner_bank_id(self, cr, uid, context=None):
26+ user = self.pool.get('res.users').read(
27+ cr, uid, uid, ['company_id'], context=context)
28+ if user['company_id']:
29+ bank_ids = self.pool.get('res.partner.bank').search(
30+ cr, uid, [('company_id', '=', user['company_id'][0])])
31+ if len(bank_ids) == 1:
32+ return bank_ids[0]
33+ return False
34+
35+ def _default_debit_account_id(self, cr, uid, context=None):
36+ account_def = self.pool.get('ir.property').get(
37+ cr, uid, 'property_account_receivable',
38+ 'res.partner', context=context)
39+ return account_def and account_def.id or False
40+
41+ def _default_credit_account_id(self, cr, uid, context=None):
42+ account_def = self.pool.get('ir.property').get(
43+ cr, uid, 'property_account_payable',
44+ 'res.partner', context=context)
45+ return account_def and account_def.id or False
46
47 def find(self, cr, uid, journal_id, partner_bank_id=False, context=None):
48 domain = [('journal_id','=',journal_id)]
49@@ -143,6 +175,10 @@
50
51 _defaults = {
52 'company_id': _default_company,
53+ 'journal_id': _default_journal,
54+ 'default_debit_account_id': _default_debit_account_id,
55+ 'default_credit_account_id': _default_credit_account_id,
56+ 'partner_bank_id': _default_partner_bank_id,
57 #'multi_currency': lambda *a: False,
58 }
59 account_banking_account_settings()
60
61=== modified file 'account_banking/i18n/nl.po'
62--- account_banking/i18n/nl.po 2012-04-16 07:35:36 +0000
63+++ account_banking/i18n/nl.po 2012-05-03 12:17:23 +0000
64@@ -1057,7 +1057,7 @@
65 #. module: account_banking
66 #: help:account.banking.account.settings,default_debit_account_id:0
67 msgid "The account to use when an unexpected payment is received. This can be needed when a customer pays in advance or when no matching invoice can be found. Mind that you can correct movements before confirming them."
68-msgstr "De grootboekrekening waarop een onverwachte betaling kan worden geboekt, bijvoorbeeld in het geval van eeen klant die vooruitbetaalt of als er geen overeenkomende factuur kan worden gevonden in het systeem. Merk op dat er voor het bevestigen van de boekingen nog wijzigingen kunnen worden aangebracht."
69+msgstr "De grootboekrekening waarop een onverwachte betaling kan worden geboekt, bijvoorbeeld in het geval van een klant die vooruitbetaalt of als er geen overeenkomende factuur kan worden gevonden in het systeem. Merk op dat er voor het bevestigen van de boekingen nog wijzigingen kunnen worden aangebracht."
70
71 #. module: account_banking
72 #: field:payment.mode.type,payment_order_type:0
73
74=== modified file 'account_banking/wizard/bank_import.py'
75--- account_banking/wizard/bank_import.py 2012-02-21 23:50:13 +0000
76+++ account_banking/wizard/bank_import.py 2012-05-03 12:17:23 +0000
77@@ -423,11 +423,16 @@
78 ),
79 }
80
81+ def _default_parser_type(self, cr, uid, context=None):
82+ types = models.parser_type.get_parser_types()
83+ return types and types[0][0] or False
84+
85 _defaults = {
86 'state': 'init',
87 'company': lambda s,cr,uid,c:
88 s.pool.get('res.company')._company_default_get(
89 cr, uid, 'bank.import.transaction', context=c),
90+ 'parser': _default_parser_type,
91 }
92
93 banking_import()
94
95=== modified file 'account_banking/wizard/bank_import_view.xml'
96--- account_banking/wizard/bank_import_view.xml 2012-02-17 23:36:43 +0000
97+++ account_banking/wizard/bank_import_view.xml 2012-05-03 12:17:23 +0000
98@@ -34,7 +34,8 @@
99 <field name="log" colspan="4" nolabel="1" width="500"/>
100 </page>
101 <page attrs="{'invisible': [('state', '!=', 'ready')]}" string="Statements">
102- <field name="statement_ids" colspan="4" nolabel="1"/>
103+ <field name="statement_ids" colspan="4" nolabel="1"
104+ attrs="{'invisible': [('state', '!=', 'ready')]}" />
105 </page>
106 </notebook>
107 <group colspan="2" >

Subscribers

People subscribed via source and target branches