Banking Addons

Merge lp:~therp-nl/banking-addons/6.1-check_statement_date_period_id into lp:banking-addons/6.1

  1. 6.1-check_statement_date_period_id
  2. Merge into 6.1
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 142
Proposed branch: lp:~therp-nl/banking-addons/6.1-check_statement_date_period_id
Merge into: lp:banking-addons/6.1
Diff against target: 20 lines (+10/-0)
1 file modified
account_banking/wizard/bank_import.py (+10/-0)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/6.1-check_statement_date_period_id
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Approve
Review via email: mp+137990@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Seems good to me.

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking/wizard/bank_import.py'
2--- account_banking/wizard/bank_import.py 2012-06-26 09:46:07 +0000
3+++ account_banking/wizard/bank_import.py 2012-12-04 20:51:33 +0000
4@@ -263,6 +263,16 @@
5 ('date_stop','>=',statement.date),
6 ('special', '=', False)])
7
8+ if not period_ids:
9+ results.log.append(
10+ _('No period found covering statement date %(date)s, '
11+ 'statement %(id)s skipped') % {
12+ 'date': statement.date,
13+ 'id': statement.id,
14+ }
15+ )
16+ continue
17+
18 # Create the bank statement record
19 statement_id = statement_obj.create(cursor, uid, dict(
20 name = statement.id,

Subscribers

People subscribed via source and target branches