Merge lp:~therp-nl/aeroo/6.1-lp1182780-error_in_report_menu into lp:aeroo/openerp6.1.x

Proposed by Stefan Rijnhart (Opener)
Status: Needs review
Proposed branch: lp:~therp-nl/aeroo/6.1-lp1182780-error_in_report_menu
Merge into: lp:aeroo/openerp6.1.x
Diff against target: 18 lines (+5/-4)
1 file modified
report_aeroo/report_xml.py (+5/-4)
To merge this branch: bzr merge lp:~therp-nl/aeroo/6.1-lp1182780-error_in_report_menu
Reviewer Review Type Date Requested Status
Alejandro Santana (community) Approve
Aeroo Reports Team Pending
Review via email: mp+169451@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alejandro Santana (alejandrosantana) wrote :

Tested: fixes the problem.

review: Approve

Unmerged revisions

6. By Stefan Rijnhart (Opener)

[FIX] 'List index out of range' when opening items in Settings->Technical->Actions->Reports

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'report_aeroo/report_xml.py'
2--- report_aeroo/report_xml.py 2013-05-16 15:49:25 +0000
3+++ report_aeroo/report_xml.py 2013-06-14 14:38:37 +0000
4@@ -388,10 +388,11 @@
5 if not (deferred_proc_module and deferred_proc_module['state'] in ('installed', 'to upgrade')):
6 doc = etree.XML(res['arch'])
7 deferred_node = doc.xpath("//field[@name='deferred']")
8- deferred_node[0].attrib['invisible'] = '1'
9- deferred_limit_node = doc.xpath("//field[@name='deferred_limit']")
10- deferred_limit_node[0].attrib['invisible'] = '1'
11- res['arch'] = etree.tostring(doc)
12+ if deferred_node:
13+ deferred_node[0].attrib['invisible'] = '1'
14+ deferred_limit_node = doc.xpath("//field[@name='deferred_limit']")
15+ deferred_limit_node[0].attrib['invisible'] = '1'
16+ res['arch'] = etree.tostring(doc)
17 ############################################
18 return res
19

Subscribers

People subscribed via source and target branches