Merge lp:~therp-nl/account-invoicing/7.0-add_account_invoice_partner into lp:~account-core-editors/account-invoicing/7.0

[Stefan Rijnhart (Opener)]

[Stéphane Bidoul (Acsone) (sbi)]

Would it not be better to try to submit it as a (usability) bug first, and if accepted as such, patch it on the OCB branch?

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Stéphane,

I wondered about that. Reported here: https://bugs.launchpad.net/openobject-addons/+bug/1213852. I'll set this to work in progress till there is a response. Meanwhile, I refactored to use the same mechanisme as is used to select the invoicing contact in the Sale module.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Stefan,

I have seen your contribution and I see this module IMHO a little dangerous, because with it you are avoiding selecting any other contact that it isn't the invoice contact (or even the company). I think that the desirable behaviour must be that you can select any contact, but the invoice contact appear highlighted in first place and with some text to identify it. This can be extended also to the other types of contacts. For example:

- Contact 1, Company A [invoice]
- Company A
- Contact 2, Company A [delivery]
- Contact 3, Company A [other]

What do you think?

Regards.

review: Needs Information

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Pedro,

your observation is correct. That would be an argument to keep this functionality in an optional module instead of the core. I like the idea of annotating contacts with their contact type, but the use case here is simply that if an invoice contact is defined, then that contact should be used whenever an invoice is sent.

[Pedro Manuel Baeza (pedro.baeza)]

OK about that, Stefan.

I only see one problem in the module: you may insert one condition to check if the selected partner is already an invoice contact, because you can have more than one invoice contact, and in this way you are virtually forbidding to select second and sucessive invoice contacts, because they are going to be reverted to the first invoice contact.

Regards.

review: Needs Fixing

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Pedro,

did you check the address_get() method in base/res/res_partner.py? Seems to me that this method does exactly what you request.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Stefan,

Indeed, it works. I didn't try the module and reading only the module code I saw that problem, but address_get() resolves it.

Sorry for bothering you.

Regards.

review: Approve (code review and test)

[Stefan Rijnhart (Opener) (stefan-opener)]

@Pedro: no bother at all, thanks for the review!

[Stefan Rijnhart (Opener) (stefan-opener)]

I'm setting this to 'Needs freview again' after the related bug on openobject-addons has reluctantly been confirmed some months ago with 'low' priority. I could propose to OCB, but I would prefer to have this as an optional module now and see if this could get integrated in OpenERP 8.

[Holger Brunn (Therp) (hbrunn)]

#38 ... when selecting [what?] that ...
#89ff wouldn't the code be more clear if you did

my_new_partner_id = None
if partner_id:
  my_new_partner_id =

result = super(my_new_partner_id or partner_id)

if my_new_partner_id != partner_id:
  result[value]['partner_id'] = my_new_partner_id
?

It took me a while to convince myself that the current implementation can't run into recursion problems

review: Needs Fixing (code review)

[lp:~therp-nl/account-invoicing/7.0-add_account_invoice_partner]

22. By Stefan Rijnhart (Opener) on 2014-02-24

[FIX] Module description

23. By Stefan Rijnhart (Opener) on 2014-02-24

[IMP] Simplify the logic and remove nonsense restart of the inheritance
 chain. Fix class name capitalization

[Stefan Rijnhart (Opener) (stefan-opener)]

Holger, thanks for the review!

I repaired the mangled module description and simplified the code. The complexity was on purpose to try and restart the inheritance chain with the new partner, but that would not have worked anyway as onchange overrides typically would inject their changes on the result of the super, based on the original input (the old partner).

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

=== added directory 'account_invoice_partner'
=== added file 'account_invoice_partner/__init__.py'
--- account_invoice_partner/__init__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_partner/__init__.py	2014-02-24 15:12:28 +0000
@@ -0,0 +1,1 @@
+import model

=== added file 'account_invoice_partner/__openerp__.py'
--- account_invoice_partner/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_partner/__openerp__.py	2014-02-24 15:12:28 +0000
@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2012-2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name" : "Automatically select invoicing partner on invoice",
+    "version" : "0.1",
+    "author" : "Therp BV",
+    "category": 'Accounting & Finance',
+    "description": """
+On an invoice, when selecting a partner of any other type than 'invoice',
+replace the partner by an invoice contact if found.
+    """,
+    'website': 'https://launchpad.net/account-invoicing',
+    'depends' : ['account'],
+}

=== added directory 'account_invoice_partner/model'
=== added file 'account_invoice_partner/model/__init__.py'
--- account_invoice_partner/model/__init__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_partner/model/__init__.py	2014-02-24 15:12:28 +0000
@@ -0,0 +1,1 @@
+import account_invoice

=== added file 'account_invoice_partner/model/account_invoice.py'
--- account_invoice_partner/model/account_invoice.py	1970-01-01 00:00:00 +0000
+++ account_invoice_partner/model/account_invoice.py	2014-02-24 15:12:28 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openerp.osv import orm
+
+
+class AccountInvoice(orm.Model):
+    _inherit = 'account.invoice'
+
+    def onchange_partner_id(
+            self, cr, uid, ids, type, partner_id,
+            date_invoice=False, payment_term=False,
+            partner_bank_id=False, company_id=False):
+        """
+        Replace the selected partner with the preferred invoice contact
+        """
+        partner_invoice_id = partner_id
+        if partner_id:
+            partner_invoice_id = self.pool.get('res.partner').address_get(
+                cr, uid, [partner_id], adr_pref=['invoice'])['invoice']
+        result = super(AccountInvoice, self).onchange_partner_id(
+            cr, uid, ids, type, partner_invoice_id,
+            date_invoice=date_invoice, payment_term=payment_term,
+            partner_bank_id=partner_bank_id, company_id=company_id)
+        if partner_invoice_id != partner_id:
+            result['value']['partner_id'] = partner_invoice_id
+        return result